From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2N3FGmTI4mHNlQAAgWs5BA (envelope-from ) for ; Sat, 15 Jan 2022 14:13:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qDhcGGTI4mHxXQEA9RJhRA (envelope-from ) for ; Sat, 15 Jan 2022 14:13:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39DE329791 for ; Sat, 15 Jan 2022 14:13:08 +0100 (CET) Received: from localhost ([::1]:52540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8irj-000886-BQ for larch@yhetil.org; Sat, 15 Jan 2022 08:13:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8im4-00050t-Mi for emacs-orgmode@gnu.org; Sat, 15 Jan 2022 08:07:16 -0500 Received: from ciao.gmane.io ([116.202.254.214]:42796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8im0-00086C-CO for emacs-orgmode@gnu.org; Sat, 15 Jan 2022 08:07:13 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n8ilh-0004in-Jq for emacs-orgmode@gnu.org; Sat, 15 Jan 2022 14:06:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] make test: Make failure results more verbose Date: Sat, 15 Jan 2022 20:06:44 +0700 Message-ID: References: <87ee5q5lic.fsf@localhost> <87lezrr3i7.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642252388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qT0LwlJueY8icoEadnDiayDichzKYWOewG+QUiZp+LA=; b=sk8iU+JpxgaBxu7t7j7G8d1gsLUkbHrMlhN3Cw6kBMMMI1cSpzF3F7EHDlXqaJHZfFNwVv /1bJQ01pXws418Oql1GVjjBrXDjKQeD7kvc2I53pptHSjBLB9BtsMYp/Pj/f2JimYBxzFS Uplc0yuXA3OlWGlhSTHnFs6GXy5l/tfg2WO20yIum0NpnWjiTCvWbeY+fXO+m17CbVHBR5 97f8rLf2pfEyXNMkFHs/k+8Oto5tAQX4tsIHMkcpljCSBcERHfwKpA5sLOaL/z7npiHMbF 7ieZzPQ8tp0BFzOKcSFWqmaHsuKzzrkwCsuEwmLt73+0z5TopuGMGfDd6TRzXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642252388; a=rsa-sha256; cv=none; b=q8Bc9GBcaVLmQSCUZ4FTh+onpTPltdUXHwImfpIGrZN2EOs6+qXhnYMZuuRwFwBDSPW0Vn 6pYAwnSFDRAtYL7kHnjiNsa9j3AzhpKRE0nK9YYlMnQSQPt2UsSBFtyw5qoTijiw7IEEfS BHeQ/QmCepOS+Ttmw1cwUBq8Pt0I0pGx/hCaTJYqbCt8iwlbPwkwQiaX9iYo4WdTPCZX86 yvJWlaxKXMGWxlTRJ+0yWorEA9llSKkVo4JDKD/hd/uXxyJepuaC512uI5Up22Ipo2dRKC EcL6d0ff7HRwvXqL/hK6jxk4zD05g2uUo6Ej/YXA7veauqbSaIYmxz98A1UrUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 39DE329791 X-Spam-Score: -3.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7c5E9LH8Leyy A couple of additional remarks. On 15/01/2022 19:52, Max Nikulin wrote: > On 02/01/2022 20:12, Ihor Radchenko wrote: > >> Subject: [PATCH] make test: Make failure results more verbose > > At first it was not clear to me that only *summary* of test results is > affected. Should not the variable be named BTEST_ERT_VERBOSE_SUMMARY instead of just BTEST_ERT_VERBOSE due to this reason? >>>> I am unsure if this line or local.mk has priority. I am unsure the the >>>> following is better as well. >>>> BTEST_ERT_VERBOSE ?= yes >>> >>> I am not very familiar with Makefile conventions. Just followed the >>> existing settings in the same file. All other BTEST_ERT_* settings just >>> use "=". I have found an example when "?=" is better. It is possible to export BTEST_ERT_VERBOSE from shell (or set in in the environment of continuous integration runner) and the value will not be overridden. Quick tests shell equivalent: BTEST_ERT_VERBOSE= make test currently it have to be written only as make test-dirty BTEST_ERT_VERBOSE=