From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x
Date: Sat, 7 Aug 2021 00:10:29 +0700 [thread overview]
Message-ID: <sejqe6$16ov$1@ciao.gmane.io> (raw)
In-Reply-To: <87mtpwhwrj.fsf@ucc.asn.au>
On 05/08/2021 19:59, Timothy wrote:
>
>> Restore compatibility with Emacs-24.3.
>
> FYI Emacs 24 is no longer Org’s minimum version, from the next release onward
> it will be Emacs 25.
Timothy, I have seen that discussion. For me it does not matter in which
way org-agenda.el will be fixed: by adding (require 'subr-x) or by using
string= instead of string-empty-p. Both variants work with Emacs-26.3.
The point is that "make single" should work without warnings and in the
case of mixed install users should not get confusing errors that
resemble real issues.
The only reason why I suggested namely to avoid string-empty-p is that
compatibility with Emacs-24.3 is still declared in Org sources.
next prev parent reply other threads:[~2021-08-06 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:24 Bug: org-agenda-highlight-todo: Symbol’s function definition is void: string-empty-p [9.4.6 (9.4.6-11-g1ee52c-elpa @ /home/vmg/.emacs.d/elpa/org-20210726/)] Вячеслав Гришин
2021-08-04 1:41 ` Tim Cross
2021-08-04 21:36 ` Вячеслав Гришин
2021-08-04 15:20 ` [PATCH] org-agenda.el: Avoid dependency on subr-x Maxim Nikulin
2021-08-04 21:41 ` Вячеслав Гришин
2021-08-05 17:04 ` Maxim Nikulin
2021-08-04 22:11 ` Tim Cross
2021-08-05 11:55 ` Maxim Nikulin
2021-08-05 12:59 ` Timothy
2021-08-06 17:10 ` Maxim Nikulin [this message]
2021-08-06 20:30 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='sejqe6$16ov$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).