From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x
Date: Thu, 5 Aug 2021 18:55:46 +0700 [thread overview]
Message-ID: <segjk4$3jf$1@ciao.gmane.io> (raw)
In-Reply-To: <87a6lwluvx.fsf@gmail.com>
The patch is created for the maint branch.
I have reordered some part of the quoted message.
On 05/08/2021 05:11, Tim Cross wrote:
> I don't think this patch is required, especially since we have not had
> any bug reported relating to that version.
org-agenda.el (and some other files) should be fixed anyway.
make single
...
Compiling single /home/ubuntu/org-mode/lisp/org-agenda.el...
In end of data:
org-agenda.el:10769:1:Warning: the function ‘string-empty-p’ is not known to
be defined.
(log for emacs-25.2.2)
> Note that compatibility with 24.3 was not the cause of the OP original
> issue (they were running 26.3).
I just do not have enough experience with elisp to suggest a patch to
explicitly notify users that they have mixed org install. On the other
hand, particular symptom from the report can be easily mitigated.
> Do we really want to maintain compatibility with Emacs 24.3?
There is the only place in org where `string-empty-p' is used. There is
no (require 'subr-x) in org-agenda.el. Notice
lisp/org.el:10: ;; Package-Requires: ((emacs "24.3"))
Till this line is updated, I suppose, patches should respect it,
especially for the maint branch. Unfortunately new org cite feature
recently merged to master relies on some rx features unavailable even in
Emacs-26.3 (Ubuntu-20.04 LTS focal).
> That
> version was released over 8 years ago and I suspect there are other
> areas of org which are not compatible with that version. Note also that
> the subr-x and string-empty-p were introduced in Emacs 24.4. If we are
> going to support Emacs 24, I think it is reasonable it be 24.4 rather
> than aiming for all 24 releases.
It seems, RedHat-7 and thus CentOS-7 were released with Emacs-24.3. I
have no idea how many users run these flavors on desktops and are
permitted to update Org to the latest version. Accordingly to
https://wiki.centos.org/About/Product
end of lifetime dates for CentOS-7 are 2020-08-06 for full updates and
2024-06-30 for maintenance updates.
next prev parent reply other threads:[~2021-08-05 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:24 Bug: org-agenda-highlight-todo: Symbol’s function definition is void: string-empty-p [9.4.6 (9.4.6-11-g1ee52c-elpa @ /home/vmg/.emacs.d/elpa/org-20210726/)] Вячеслав Гришин
2021-08-04 1:41 ` Tim Cross
2021-08-04 21:36 ` Вячеслав Гришин
2021-08-04 15:20 ` [PATCH] org-agenda.el: Avoid dependency on subr-x Maxim Nikulin
2021-08-04 21:41 ` Вячеслав Гришин
2021-08-05 17:04 ` Maxim Nikulin
2021-08-04 22:11 ` Tim Cross
2021-08-05 11:55 ` Maxim Nikulin [this message]
2021-08-05 12:59 ` Timothy
2021-08-06 17:10 ` Maxim Nikulin
2021-08-06 20:30 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='segjk4$3jf$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).