From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eGp3HezRC2GQlgAAgWs5BA (envelope-from ) for ; Thu, 05 Aug 2021 13:56:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UE68GOzRC2HkdwAAB5/wlQ (envelope-from ) for ; Thu, 05 Aug 2021 11:56:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B12939D4 for ; Thu, 5 Aug 2021 13:56:27 +0200 (CEST) Received: from localhost ([::1]:44612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBbz6-00079R-Qu for larch@yhetil.org; Thu, 05 Aug 2021 07:56:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBbyi-00077Z-MV for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 07:56:00 -0400 Received: from ciao.gmane.io ([116.202.254.214]:43970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBbyf-0004uL-UB for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 07:56:00 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mBbyc-000181-Ua for emacs-orgmode@gnu.org; Thu, 05 Aug 2021 13:55:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x Date: Thu, 5 Aug 2021 18:55:46 +0700 Message-ID: References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> <87a6lwluvx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 X-Woof-Patch: Confirmed In-Reply-To: <87a6lwluvx.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.132, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628164588; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=18EncT68zFAOsn1x1313AanU7ECpW4P3gzMR/5CObpo=; b=gTqNWaM1qQyfCM/YX425Jeke/HhanJGtfQskY+1+Z4Nm649JcN+Q6mlW9my6G/MMC9H1va cFKDMcIwttEofWEZTwbTUdYskgAFNYWnlhZdHmLGVugddHIL2jNlbtIutUSNvyR5TiOafh Qn1R27QoLjyv6XM5s1JVtLD4jEFzrKnOyWh4Y1MpQ67gCRjndzoMYYA5PUqWIGt0fopeIW j8hqSISuyeH2A4S9NK4u1pL2QkyxvbSugFUVGzXJRSNUboK4A+zhht73QGsBUCBXOdqQ2v TuothbliUPtnNEl7/uyfUezGE93oZ1/JTXOF2lNO5zTEgCiiC7bhAygzcx2HWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628164588; a=rsa-sha256; cv=none; b=dW0MdO/nSObeR0ft9b4Qj+bQvf/ggtHfSUbX+pCzCUOlKilFAjmq4EPxY1loiDrjkFGQ1l nR3DkfDTyu92lhtyqj1CJh9v3/FkHX9cOYrxFpon3RQLnKoc1shdpNzv4mWv2Wubtb7SE9 nTQZol00PrtF8xCCdhX8FWL2mqRLlsOgJ4bXtVxyXIDRkgI9ZXgwQFlq9UEw997+zC/lwV xKv0N4M8d0Ay/m/oZ8WrR0qQ6ZViYdQoWHMVeySIvE66uYJnupdrigUdJgVb8r8wfCxJjt kaQfHZiTS98adN8myC8bTqGiu4uDabe4vo3aP6aPZSfUlTpLelzflNzDU8h9PA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 5B12939D4 X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2sF4MErFdCjm The patch is created for the maint branch. I have reordered some part of the quoted message. On 05/08/2021 05:11, Tim Cross wrote: > I don't think this patch is required, especially since we have not had > any bug reported relating to that version. org-agenda.el (and some other files) should be fixed anyway. make single ... Compiling single /home/ubuntu/org-mode/lisp/org-agenda.el... In end of data: org-agenda.el:10769:1:Warning: the function ‘string-empty-p’ is not known to be defined. (log for emacs-25.2.2) > Note that compatibility with 24.3 was not the cause of the OP original > issue (they were running 26.3). I just do not have enough experience with elisp to suggest a patch to explicitly notify users that they have mixed org install. On the other hand, particular symptom from the report can be easily mitigated. > Do we really want to maintain compatibility with Emacs 24.3? There is the only place in org where `string-empty-p' is used. There is no (require 'subr-x) in org-agenda.el. Notice lisp/org.el:10: ;; Package-Requires: ((emacs "24.3")) Till this line is updated, I suppose, patches should respect it, especially for the maint branch. Unfortunately new org cite feature recently merged to master relies on some rx features unavailable even in Emacs-26.3 (Ubuntu-20.04 LTS focal). > That > version was released over 8 years ago and I suspect there are other > areas of org which are not compatible with that version. Note also that > the subr-x and string-empty-p were introduced in Emacs 24.4. If we are > going to support Emacs 24, I think it is reasonable it be 24.4 rather > than aiming for all 24 releases. It seems, RedHat-7 and thus CentOS-7 were released with Emacs-24.3. I have no idea how many users run these flavors on desktops and are permitted to update Org to the latest version. Accordingly to https://wiki.centos.org/About/Product end of lifetime dates for CentOS-7 are 2020-08-06 for full updates and 2024-06-30 for maintenance updates.