From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-agenda.el: Avoid dependency on subr-x
Date: Wed, 4 Aug 2021 22:20:47 +0700 [thread overview]
Message-ID: <seeb8h$364$1@ciao.gmane.io> (raw)
In-Reply-To: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru>
* lisp/org-agenda.el (org-agenda-highlight-todo): Do not use `string-empty-p'.
Restore compatibility with Emacs-24.3.
---
lisp/org-agenda.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index c3fbabc01..b6cd895bc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7080,7 +7080,7 @@ The optional argument TYPE tells the agenda type."
(setq x
(concat
(substring x 0 (match-end 1))
- (unless (string-empty-p org-agenda-todo-keyword-format)
+ (unless (string= org-agenda-todo-keyword-format "")
(format org-agenda-todo-keyword-format
(match-string 2 x)))
;; Remove `display' property as the icon could leak
--
2.25.1
next prev parent reply other threads:[~2021-08-04 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:24 Bug: org-agenda-highlight-todo: Symbol’s function definition is void: string-empty-p [9.4.6 (9.4.6-11-g1ee52c-elpa @ /home/vmg/.emacs.d/elpa/org-20210726/)] Вячеслав Гришин
2021-08-04 1:41 ` Tim Cross
2021-08-04 21:36 ` Вячеслав Гришин
2021-08-04 15:20 ` Maxim Nikulin [this message]
2021-08-04 21:41 ` [PATCH] org-agenda.el: Avoid dependency on subr-x Вячеслав Гришин
2021-08-05 17:04 ` Maxim Nikulin
2021-08-04 22:11 ` Tim Cross
2021-08-05 11:55 ` Maxim Nikulin
2021-08-05 12:59 ` Timothy
2021-08-06 17:10 ` Maxim Nikulin
2021-08-06 20:30 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='seeb8h$364$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).