From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id k4z/GCltDWEimQAAgWs5BA (envelope-from ) for ; Fri, 06 Aug 2021 19:11:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8DPhEyltDWEaOwAAbx9fmQ (envelope-from ) for ; Fri, 06 Aug 2021 17:11:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B87718BF for ; Fri, 6 Aug 2021 19:11:04 +0200 (CEST) Received: from localhost ([::1]:36776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC3N8-00013v-FO for larch@yhetil.org; Fri, 06 Aug 2021 13:11:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC3Mj-00013f-UJ for emacs-orgmode@gnu.org; Fri, 06 Aug 2021 13:10:37 -0400 Received: from ciao.gmane.io ([116.202.254.214]:36648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC3Mi-00022b-LN for emacs-orgmode@gnu.org; Fri, 06 Aug 2021 13:10:37 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mC3Mg-000AOt-Vq for emacs-orgmode@gnu.org; Fri, 06 Aug 2021 19:10:34 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x Date: Sat, 7 Aug 2021 00:10:29 +0700 Message-ID: References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> <87mtpwhwrj.fsf@ucc.asn.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <87mtpwhwrj.fsf@ucc.asn.au> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.619, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628269865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FFNThRcrDZqVvYKekWweWlm572fCBROGDEx6InLysgM=; b=oOgCxwQFXUZZTm0PZpQkpEMQ/ikpcmL6Kz4fLVFrnLUBh9izDFeF8iNkBGnw7LxZeBamPb HcmcYf/w7PHc7zrvX74kzFRwjWVY2F5s+UBejCFW4BXpZHz+wUNyKRrf7jz6SXeE28tvJ1 o6FpT0l5Xlce3immPU8nMJ28yv3HIzLmzT+5kd8jBG7HEOrOZ4DQRigEgtoYqYdr8j+K6v 5deXYM0ijXPDu+d6M/Tlg5el9KpjSoVNQp9KS3iqCheanZU7fMEP1sBxpXfE8Z30DY1pL1 Ou16FWBL35DinTwaeAYrCMe1yeMper5CHLClyDnprJ9Ho06TgylkCOsAUACVWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628269865; a=rsa-sha256; cv=none; b=XVI0dFEm4UBArsrQXJ6EcL6WSD6XUoJq2REoSsQWdU4BPY40ZpuOaJKtAfrr4qi0xnH73E OXbFlfi7CPk1HTWEqVPV3nAjw+E/s3qoaFlvVolxDUldc2qiuNzhfa/1x4xMC1U9FhDXQ3 Hkvw+c5pVAEKkxEIX4QTtq+xMKzxVt1V5RPMBD0NZK2MRTeO84qf3Up/ihikASLGDU3abv n1SbqxLH7VfySNXNyde2STeOFPb0UP+U2GwZs3oFofhy3TD83+e2Mln3XIW6kRbkAWHEBO KPJpj84aV5St7ZuLS79QxAzcfgMeX1ZK9xDvBXLGmdGQX0NdFoIwofkvJqIVuA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 4B87718BF X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: INSwrdu1oiY7 On 05/08/2021 19:59, Timothy wrote: > >> Restore compatibility with Emacs-24.3. > > FYI Emacs 24 is no longer Org’s minimum version, from the next release onward > it will be Emacs 25. Timothy, I have seen that discussion. For me it does not matter in which way org-agenda.el will be fixed: by adding (require 'subr-x) or by using string= instead of string-empty-p. Both variants work with Emacs-26.3. The point is that "make single" should work without warnings and in the case of mixed install users should not get confusing errors that resemble real issues. The only reason why I suggested namely to avoid string-empty-p is that compatibility with Emacs-24.3 is still declared in Org sources.