Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[Dave Abrahams]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

This function was misbehaving in a number of ways.  The enclosed patch
represents the changes necessary to make it work properly, accumulated
over several weeks of testing.  Sorry if the description is a bit vague.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-behavior-of-org-agenda-tree-to-indirect-buffer.patch --]
[-- Type: text/x-patch, Size: 1563 bytes --]

From c5128d1666e5fbe29a2fdfd6ee51622f05c42e9b Mon Sep 17 00:00:00 2001
From: Dave Abrahams <dave@boostpro.com>
Date: Fri, 17 Feb 2012 22:44:13 -1000
Subject: [PATCH] Fix behavior of org-agenda-tree-to-indirect-buffer

---
 lisp/org-agenda.el |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 780794e..0c32b48 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7202,16 +7202,19 @@ use the dedicated frame)."
   (if (and current-prefix-arg (listp current-prefix-arg))
       (org-agenda-do-tree-to-indirect-buffer)
     (let ((agenda-window (selected-window))
-          (indirect-window (get-buffer-window org-last-indirect-buffer)))
+	  (indirect-window 
+	   (and org-last-indirect-buffer
+		(get-buffer-window org-last-indirect-buffer))))
       (save-window-excursion (org-agenda-do-tree-to-indirect-buffer))
       (unwind-protect
-          (progn
-            (unless indirect-window
+	  (progn
+            (unless (and indirect-window (window-live-p indirect-window))
               (setq indirect-window (split-window agenda-window)))
             (select-window indirect-window)
             (switch-to-buffer org-last-indirect-buffer :norecord)
+	    (org-set-visibility-according-to-property)
             (fit-window-to-buffer indirect-window))
-        (select-window agenda-window)))))
+	(select-window agenda-window)))))
 
 (defun org-agenda-do-tree-to-indirect-buffer ()
   "Same as `org-agenda-tree-to-indirect-buffer' without saving window."
-- 
1.7.5.4


[-- Attachment #3: Type: text/plain, Size: 232 bytes --]



Emacs  : GNU Emacs 24.0.92.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
 of 2011-12-22 on bob.porkrind.org
Package: Org-mode version 7.8.02 (release_7.7.796.gc512)
-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

Hi Dave,

At Fri, 17 Feb 2012 22:48:13 -1000,
Dave Abrahams wrote:
>
> [1  <text/plain (7bit)>]
>
>
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>      http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> This function was misbehaving in a number of ways.  The enclosed patch
> represents the changes necessary to make it work properly, accumulated
> over several weeks of testing.  Sorry if the description is a bit vague.

Thanks for the patch. I implemented the first to modifications (handle
org-last-indirect-buffer being nil and window-live-p
indirect-window). These were indeed bugs or glitches.

The third modification (set visibility according to property) is a new
feature. Currently org-tree-to-indirect buffer does not use the
VISIBILITY property but it makes sense to me to do so.

I'll check this out and see to implement this.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[Dave Abrahams]

on Sat Feb 25 2012, David Maus <dmaus-AT-ictsoc.de> wrote:

> Hi Dave,
>
> At Fri, 17 Feb 2012 22:48:13 -1000,
> Dave Abrahams wrote:
>>
>> [1  <text/plain (7bit)>]
>>
>>
>> Remember to cover the basics, that is, what you expected to happen and
>> what in fact did happen.  You don't know how to make a good report?  See
>>
>>      http://orgmode.org/manual/Feedback.html#Feedback
>>
>> Your bug report will be posted to the Org-mode mailing list.
>> ------------------------------------------------------------------------
>>
>> This function was misbehaving in a number of ways.  The enclosed patch
>> represents the changes necessary to make it work properly, accumulated
>> over several weeks of testing.  Sorry if the description is a bit vague.
>
> Thanks for the patch. I implemented the first to modifications (handle
> org-last-indirect-buffer being nil and window-live-p
> indirect-window). 

Sorry, I can't parse that last sentence, and as a result I'm having
trouble understanding the rest of the message.

> These were indeed bugs or glitches.
>
> The third modification (set visibility according to property) is a new
> feature. Currently org-tree-to-indirect buffer does not use the
> VISIBILITY property but it makes sense to me to do so.
>
> I'll check this out and see to implement this.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

At Sat, 25 Feb 2012 08:34:22 -0500,
Dave Abrahams wrote:
>
>
> on Sat Feb 25 2012, David Maus <dmaus-AT-ictsoc.de> wrote:
>
> > Hi Dave,
> >
> > At Fri, 17 Feb 2012 22:48:13 -1000,
> > Dave Abrahams wrote:
> >>
> >> [1  <text/plain (7bit)>]
> >>
> >>
> >> Remember to cover the basics, that is, what you expected to happen and
> >> what in fact did happen.  You don't know how to make a good report?  See
> >>
> >>      http://orgmode.org/manual/Feedback.html#Feedback
> >>
> >> Your bug report will be posted to the Org-mode mailing list.
> >> ------------------------------------------------------------------------
> >>
> >> This function was misbehaving in a number of ways.  The enclosed patch
> >> represents the changes necessary to make it work properly, accumulated
> >> over several weeks of testing.  Sorry if the description is a bit vague.
> >
> > Thanks for the patch. I implemented the first to modifications (handle
> > org-last-indirect-buffer being nil and window-live-p
> > indirect-window).

Your patch contained three modifications to `org-agenda-tree-to-indirect-buffer':

 1. handle the case where there was no indirect buffer yet, i.e.
    (eq org-last-indirect-buffer nil)

    => applied

 2. handle the case where the window of the last indirect buffer is no
    longer live

    => applied

 3. set the subtree visibility according to the VISIBILITY property
    after the indirect buffer was created

    => no applied

The third modification does not fix a bug, but is a useful
feature. This should be implemented in `org-tree-to-indirect-buffer'
and I'm going to do exactly this.

Better?

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[Dave Abrahams]

on Sat Feb 25 2012, Dave Abrahams <dave-AT-boostpro.com> wrote:

> on Sat Feb 25 2012, David Maus <dmaus-AT-ictsoc.de> wrote:
>
>> Hi Dave,
>>
>> At Fri, 17 Feb 2012 22:48:13 -1000,
>> Dave Abrahams wrote:
>>>
>>> [1  <text/plain (7bit)>]
>>>
>>>
>>> Remember to cover the basics, that is, what you expected to happen and
>>> what in fact did happen.  You don't know how to make a good report?  See
>>>
>>>      http://orgmode.org/manual/Feedback.html#Feedback
>>>
>>> Your bug report will be posted to the Org-mode mailing list.
>>> ------------------------------------------------------------------------
>>>
>>> This function was misbehaving in a number of ways.  The enclosed patch
>>> represents the changes necessary to make it work properly, accumulated
>>> over several weeks of testing.  Sorry if the description is a bit vague.
>>
>> Thanks for the patch. I implemented the first to modifications (handle
>> org-last-indirect-buffer being nil and window-live-p
>> indirect-window). 
>
> Sorry, I can't parse that last sentence, and as a result I'm having
> trouble understanding the rest of the message.
>
>> These were indeed bugs or glitches.
>>
>> The third modification (set visibility according to property) is a new
>> feature. Currently org-tree-to-indirect buffer does not use the
>> VISIBILITY property but it makes sense to me to do so.

Well, new feature or not, org-tree-to-indirect-buffer stopped behaving
correctly for me when it was added, and I had to make adjustments.

>> I'll check this out and see to implement this.

Thanks.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com