From: David Maus <dmaus@ictsoc.de>
To: Dave Abrahams <dave@boostpro.com>
Cc: David Maus <dmaus@ictsoc.de>, emacs-orgmode@gnu.org
Subject: Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]
Date: Sat, 25 Feb 2012 16:55:43 +0100 [thread overview]
Message-ID: <87mx86x5z4.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <m2fwdzqboh.fsf@boostpro.com>
[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]
At Sat, 25 Feb 2012 08:34:22 -0500,
Dave Abrahams wrote:
>
>
> on Sat Feb 25 2012, David Maus <dmaus-AT-ictsoc.de> wrote:
>
> > Hi Dave,
> >
> > At Fri, 17 Feb 2012 22:48:13 -1000,
> > Dave Abrahams wrote:
> >>
> >> [1 <text/plain (7bit)>]
> >>
> >>
> >> Remember to cover the basics, that is, what you expected to happen and
> >> what in fact did happen. You don't know how to make a good report? See
> >>
> >> http://orgmode.org/manual/Feedback.html#Feedback
> >>
> >> Your bug report will be posted to the Org-mode mailing list.
> >> ------------------------------------------------------------------------
> >>
> >> This function was misbehaving in a number of ways. The enclosed patch
> >> represents the changes necessary to make it work properly, accumulated
> >> over several weeks of testing. Sorry if the description is a bit vague.
> >
> > Thanks for the patch. I implemented the first to modifications (handle
> > org-last-indirect-buffer being nil and window-live-p
> > indirect-window).
Your patch contained three modifications to `org-agenda-tree-to-indirect-buffer':
1. handle the case where there was no indirect buffer yet, i.e.
(eq org-last-indirect-buffer nil)
=> applied
2. handle the case where the window of the last indirect buffer is no
longer live
=> applied
3. set the subtree visibility according to the VISIBILITY property
after the indirect buffer was created
=> no applied
The third modification does not fix a bug, but is a useful
feature. This should be implemented in `org-tree-to-indirect-buffer'
and I'm going to do exactly this.
Better?
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]
next prev parent reply other threads:[~2012-02-25 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 8:48 Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)] Dave Abrahams
2012-02-25 10:26 ` David Maus
2012-02-25 13:34 ` Dave Abrahams
2012-02-25 15:55 ` David Maus [this message]
2012-02-25 19:43 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx86x5z4.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=dave@boostpro.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).