Re: org-player and switch to lexical binding in org.el

[Michael Brand <michael.ch.brand@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi Nicolas and Paul

On Wed, Feb 3, 2016 at 6:33 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> I replaced S-expressions with functions of two arguments. The Org world
> is a better place with one less `eval'.

Just to confirm: Updating org-player.el to 1.0.1 makes Org links to
media files play again. Thank you both for your changes.

I made some thoughts about the user experience of this incompatible
change:

Following such an Org link after updating Org without taking too much
care of `org-file-apps' or as a new Org user silently falls back to
open the file e. g. directly in an Emacs buffer just as with a default
`org-file-apps'. In this situation a user may well not be aware of
that `org-file-apps' has fallen short of an application registered
there. Or, even if I read the Org News I might not be aware of all the
additions to `org-file-apps' I got under the hood. Or the user does
not read the Org News or does not understand the consequences to its
very end.

For all this I suggest a simple migration hint like the error in my
attached patch. Did I miss its disadvantage?

Michael

[-- Attachment #2: 0001-org-file-apps-add-migration-hint.patch --]
[-- Type: application/octet-stream, Size: 859 bytes --]

From b3c3cd9f07e2009068bf5952963d98924b5e4d17 Mon Sep 17 00:00:00 2001
From: Michael Brand <michael.brand@alumni.ethz.ch>
Date: Wed, 3 Feb 2016 21:37:09 +0100
Subject: [PATCH] `org-file-apps' add migration hint

* lisp/org.el (org-file-apps): Add an error when still a sexp is in
use.
---
 lisp/org.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org.el b/lisp/org.el
index c93e4e1..c2f945f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11326,6 +11326,8 @@ If the file does not exist, an error is thrown."
       (save-match-data
 	(set-match-data link-match-data)
 	(funcall cmd file link)))
+     ((consp cmd)
+      (error "Please see Org News for Version 9.0 about `org-file-apps'"))
      (t (funcall (cdr (assq 'file org-link-frame-setup)) file)))
     (and (derived-mode-p 'org-mode)
 	 (eq old-mode 'org-mode)
-- 
2.4.9 (Apple Git-60)