Re: org-html link building diff

[Carsten Dominik <carsten.dominik@gmail.com>]

Hi Tom,

I have now taken a brief look at the html-export-refactor-build-link  
patch.  I see that in addition to changing org-html, it create a new  
file, with tests.  While it is great that you have defined tests, this  
meant that I cannot simply apply he patch to the master without making  
unwanted changes.

If we build a test strucure, it should be in a completely separate  
directory, not in, for example, the lisp directory.

Could you please make me a branch which contains only the changes that  
would go into org?

And if you want to provide a test framework for Org, pleas, by all  
means, go ahead, build it and document it so that we can all use it.

Maybe we could make a "tests" subdirectory in the git repo that would  
contain it...

Thanks

- Carsten

On May 15, 2010, at 11:37 PM, Tom Breton (Tehom) wrote:

>> Hi Tom,
>>
>> what is the status of this development?  Ready for prime time?  If
>> yes, can you please rebase to master and send me the pointer to the
>> branch again?
>
> I believe it is ready, though I haven't heard any feedback.  I  
> pushed the
> changes on about the 4th of may.
>
>> Or is there still stuff unclear?  Can I help?
>
> Maybe.  I hadn't done this before, so some feedback and (if needed)
> correction would be appreciated.
>
> I had to change the url to git+ssh so it would authenticate me, but  
> when I
> pushed, it was visible in the public (non-ssh) git repo, so I  
> thought it
> was visible to everybody.  Isn't it?
>
> I thought I had done what you wanted by creating a branch for all my
> changes ever (tehom-master) and rebasing the org-html link changes  
> on that
> (html-export-refactor-build-link).  Is that working for you?  If  
> not, how
> can I fix it?
>
> Tom Breton (Tehom)
>
>

- Carsten