Re: org-html link building diff

[Carsten Dominik <carsten.dominik@gmail.com>]

Hi Tom,

On Apr 28, 2010, at 5:01 AM, Tom Breton (Tehom) wrote:

>
> The changes are essentially made and pass my tests now, there's mostly
> housekeeping now: pull, merge, push.
>
>> Yes.  Send me your name on repo.or.cz and I'll add push for you.
>> Please create your own branch and stay on it.
>
> It is "Tehom".

I have added you.

>
>> This is for having a clickable Thumbnail - I am not sure if this is
>> also handled elsewhere.
>
> I believe it is.  The only difference seems to be that the first
> builds:
>
> : <a href="foo/target.html"><img src="some.jpg"></a>
>
> all by itself and the second builds:
>
> : <img src="some.jpg" href="foo/target.html">
>
> thru `org-export-html-format-image'.

Are these equivalent?

My brain is a black hole as to why I might have made two ways.

When you have made you branch, be sure to get Sebastian Rose try it  
out - I think he has lots of image links in his setup.

>  Only the second handles
> captions.  If the captions etc are the issue, then it should all go
> thru the second.  Plus, `org-export-html-format-image' seems to be the
> right place for image code.  It would be bad if changes added to
> `org-export-html-format-image' didn't take because this other code
> handled it instead.
>
> A few questions:
>
> * Encountered while writing tests: When type is file and path is an
>   absolute filename, we do substitutions.  Like "/foo/unfoo/.././baz"
>   becomes "/foo/baz".  But we don't do them when path is relative.
>   Why not?
>
>   Is that just because we'd then need to make it relative again which
>   is more code, or is there some other reason?

Maybe the reason is that the exporten/published result will live  
somewhere else, and a relative path need to remain relative in order  
to make things work correctly.

>
> * Also found in the course of testing: "id:" links cause errors when
>   buffer is not associated with a file.  This can happen when the arg
>   body-only is passed.
>
>   * Punt id links in that case?
>
>   * Do them but avoid the filename relativizing step?


I guess either one i OK with me.  How about the people whi use this  
for jekyl bloggin engines, what would be the right behavior for them?
>
> * How do you feel about url-parse?  It's bundled with emacs, builds
>   and destructures urls.  IMO we're not at the stage where it
>   provides more help than the extra work it requires yet.

If it (our code) works, don't fix it.


- Carsten