emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Tom Breton (Tehom)" <tehom@panix.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-html link building diff
Date: Tue, 27 Apr 2010 23:01:18 -0400	[thread overview]
Message-ID: <38037a0de3b943046be643eaa83932a1.squirrel@mail.panix.com> (raw)
In-Reply-To: <6104BFDD-B075-4516-81BC-E4A9101DE284@gmail.com>


The changes are essentially made and pass my tests now, there's mostly
housekeeping now: pull, merge, push.

> Yes.  Send me your name on repo.or.cz and I'll add push for you.
> Please create your own branch and stay on it.

It is "Tehom".

> This is for having a clickable Thumbnail - I am not sure if this is
> also handled elsewhere.

I believe it is.  The only difference seems to be that the first
builds:

 : <a href="foo/target.html"><img src="some.jpg"></a>

all by itself and the second builds:

 : <img src="some.jpg" href="foo/target.html">

thru `org-export-html-format-image'.  Only the second handles
captions.  If the captions etc are the issue, then it should all go
thru the second.  Plus, `org-export-html-format-image' seems to be the
right place for image code.  It would be bad if changes added to
`org-export-html-format-image' didn't take because this other code
handled it instead.

A few questions:

 * Encountered while writing tests: When type is file and path is an
   absolute filename, we do substitutions.  Like "/foo/unfoo/.././baz"
   becomes "/foo/baz".  But we don't do them when path is relative.
   Why not?

   Is that just because we'd then need to make it relative again which
   is more code, or is there some other reason?

 * Also found in the course of testing: "id:" links cause errors when
   buffer is not associated with a file.  This can happen when the arg
   body-only is passed.

   * Punt id links in that case?

   * Do them but avoid the filename relativizing step?

 * How do you feel about url-parse?  It's bundled with emacs, builds
   and destructures urls.  IMO we're not at the stage where it
   provides more help than the extra work it requires yet.

	Tom Breton (Tehom)

  reply	other threads:[~2010-04-28  3:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18  2:13 org-html link building diff Tom Breton (Tehom)
2010-04-26  5:24 ` Carsten Dominik
2010-04-26 10:03   ` Sebastian Rose
2010-04-26 19:45   ` Tom Breton (Tehom)
2010-04-27  6:07     ` Carsten Dominik
2010-04-28  3:01       ` Tom Breton (Tehom) [this message]
2010-04-28 15:07         ` Carsten Dominik
  -- strict thread matches above, loose matches on Subject: below --
2010-04-29 22:24 Tom Breton (Tehom)
2010-05-01 12:01 ` Carsten Dominik
2010-05-15 12:29 ` Carsten Dominik
2010-05-15 21:37   ` Tom Breton (Tehom)
2010-05-16  5:03     ` Carsten Dominik
2010-05-18  0:59       ` Tom Breton (Tehom)
2010-05-18  4:47         ` Carsten Dominik
2010-05-18 12:26           ` Sebastian Rose
2010-05-16  5:20     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38037a0de3b943046be643eaa83932a1.squirrel@mail.panix.com \
    --to=tehom@panix.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).