From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tom Breton (Tehom)" Subject: Re: org-html link building diff Date: Tue, 27 Apr 2010 23:01:18 -0400 Message-ID: <38037a0de3b943046be643eaa83932a1.squirrel@mail.panix.com> References: <734f7527c1662e217d1ec2ad053118b2.squirrel@mail.panix.com> <6104BFDD-B075-4516-81BC-E4A9101DE284@gmail.com> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6xWe-0006yc-2B for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 23:01:24 -0400 Received: from [140.186.70.92] (port=41464 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6xWb-0006yK-9f for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 23:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6xWZ-0007OD-CF for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 23:01:21 -0400 Received: from mail2.panix.com ([166.84.1.73]:58524) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6xWZ-0007O0-9g for emacs-orgmode@gnu.org; Tue, 27 Apr 2010 23:01:19 -0400 In-Reply-To: <6104BFDD-B075-4516-81BC-E4A9101DE284@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org The changes are essentially made and pass my tests now, there's mostly housekeeping now: pull, merge, push. > Yes. Send me your name on repo.or.cz and I'll add push for you. > Please create your own branch and stay on it. It is "Tehom". > This is for having a clickable Thumbnail - I am not sure if this is > also handled elsewhere. I believe it is. The only difference seems to be that the first builds: : all by itself and the second builds: : thru `org-export-html-format-image'. Only the second handles captions. If the captions etc are the issue, then it should all go thru the second. Plus, `org-export-html-format-image' seems to be the right place for image code. It would be bad if changes added to `org-export-html-format-image' didn't take because this other code handled it instead. A few questions: * Encountered while writing tests: When type is file and path is an absolute filename, we do substitutions. Like "/foo/unfoo/.././baz" becomes "/foo/baz". But we don't do them when path is relative. Why not? Is that just because we'd then need to make it relative again which is more code, or is there some other reason? * Also found in the course of testing: "id:" links cause errors when buffer is not associated with a file. This can happen when the arg body-only is passed. * Punt id links in that case? * Do them but avoid the filename relativizing step? * How do you feel about url-parse? It's bundled with emacs, builds and destructures urls. IMO we're not at the stage where it provides more help than the extra work it requires yet. Tom Breton (Tehom)