From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-html link building diff Date: Wed, 28 Apr 2010 17:07:20 +0200 Message-ID: <912CEAF0-1084-4557-A298-6D4BBDD77833@gmail.com> References: <734f7527c1662e217d1ec2ad053118b2.squirrel@mail.panix.com> <6104BFDD-B075-4516-81BC-E4A9101DE284@gmail.com> <38037a0de3b943046be643eaa83932a1.squirrel@mail.panix.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O78rK-0006ES-NP for emacs-orgmode@gnu.org; Wed, 28 Apr 2010 11:07:30 -0400 Received: from [140.186.70.92] (port=44407 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O78rI-0006EC-Uo for emacs-orgmode@gnu.org; Wed, 28 Apr 2010 11:07:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O78rG-0001Q9-B6 for emacs-orgmode@gnu.org; Wed, 28 Apr 2010 11:07:28 -0400 Received: from mail-ew0-f214.google.com ([209.85.219.214]:42347) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O78rE-0001Pg-JP for emacs-orgmode@gnu.org; Wed, 28 Apr 2010 11:07:26 -0400 Received: by ewy6 with SMTP id 6so5502048ewy.32 for ; Wed, 28 Apr 2010 08:07:23 -0700 (PDT) In-Reply-To: <38037a0de3b943046be643eaa83932a1.squirrel@mail.panix.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org Hi Tom, On Apr 28, 2010, at 5:01 AM, Tom Breton (Tehom) wrote: > > The changes are essentially made and pass my tests now, there's mostly > housekeeping now: pull, merge, push. > >> Yes. Send me your name on repo.or.cz and I'll add push for you. >> Please create your own branch and stay on it. > > It is "Tehom". I have added you. > >> This is for having a clickable Thumbnail - I am not sure if this is >> also handled elsewhere. > > I believe it is. The only difference seems to be that the first > builds: > > : > > all by itself and the second builds: > > : > > thru `org-export-html-format-image'. Are these equivalent? My brain is a black hole as to why I might have made two ways. When you have made you branch, be sure to get Sebastian Rose try it out - I think he has lots of image links in his setup. > Only the second handles > captions. If the captions etc are the issue, then it should all go > thru the second. Plus, `org-export-html-format-image' seems to be the > right place for image code. It would be bad if changes added to > `org-export-html-format-image' didn't take because this other code > handled it instead. > > A few questions: > > * Encountered while writing tests: When type is file and path is an > absolute filename, we do substitutions. Like "/foo/unfoo/.././baz" > becomes "/foo/baz". But we don't do them when path is relative. > Why not? > > Is that just because we'd then need to make it relative again which > is more code, or is there some other reason? Maybe the reason is that the exporten/published result will live somewhere else, and a relative path need to remain relative in order to make things work correctly. > > * Also found in the course of testing: "id:" links cause errors when > buffer is not associated with a file. This can happen when the arg > body-only is passed. > > * Punt id links in that case? > > * Do them but avoid the filename relativizing step? I guess either one i OK with me. How about the people whi use this for jekyl bloggin engines, what would be the right behavior for them? > > * How do you feel about url-parse? It's bundled with emacs, builds > and destructures urls. IMO we're not at the stage where it > provides more help than the extra work it requires yet. If it (our code) works, don't fix it. - Carsten