From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-html link building diff Date: Sun, 16 May 2010 07:03:22 +0200 Message-ID: <9D0A8669-60C2-462F-8235-881573A664D6@gmail.com> References: <047c96c5361a8739fc4e8bb94abeef8e.squirrel@mail.panix.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=60398 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODW0d-00038m-Qu for emacs-orgmode@gnu.org; Sun, 16 May 2010 01:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODW0c-0007Ly-AT for emacs-orgmode@gnu.org; Sun, 16 May 2010 01:03:27 -0400 Received: from mail-ew0-f216.google.com ([209.85.219.216]:61459) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODW0c-0007Lg-2p for emacs-orgmode@gnu.org; Sun, 16 May 2010 01:03:26 -0400 Received: by ewy8 with SMTP id 8so1159794ewy.8 for ; Sat, 15 May 2010 22:03:25 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org Hi Tom, I have now taken a brief look at the html-export-refactor-build-link patch. I see that in addition to changing org-html, it create a new file, with tests. While it is great that you have defined tests, this meant that I cannot simply apply he patch to the master without making unwanted changes. If we build a test strucure, it should be in a completely separate directory, not in, for example, the lisp directory. Could you please make me a branch which contains only the changes that would go into org? And if you want to provide a test framework for Org, pleas, by all means, go ahead, build it and document it so that we can all use it. Maybe we could make a "tests" subdirectory in the git repo that would contain it... Thanks - Carsten On May 15, 2010, at 11:37 PM, Tom Breton (Tehom) wrote: >> Hi Tom, >> >> what is the status of this development? Ready for prime time? If >> yes, can you please rebase to master and send me the pointer to the >> branch again? > > I believe it is ready, though I haven't heard any feedback. I > pushed the > changes on about the 4th of may. > >> Or is there still stuff unclear? Can I help? > > Maybe. I hadn't done this before, so some feedback and (if needed) > correction would be appreciated. > > I had to change the url to git+ssh so it would authenticate me, but > when I > pushed, it was visible in the public (non-ssh) git repo, so I > thought it > was visible to everybody. Isn't it? > > I thought I had done what you wanted by creating a branch for all my > changes ever (tehom-master) and rebasing the org-html link changes > on that > (html-export-refactor-build-link). Is that working for you? If > not, how > can I fix it? > > Tom Breton (Tehom) > > - Carsten