Bug in org-icalendar.el

Bug in org-icalendar.el

[Andrew Lawson]

Hi all
    Just noticed an issue with a recent commit d51a8307 which defines
org-icalendar-verify-function as nil but tests it using 'boundp. I'm
using revision a7543733... The fix is:

@@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
line."
       (while (re-search-forward re1 nil t)
        (catch :skip
          (org-agenda-skip)
-         (when (boundp 'org-icalendar-verify-function)
+         (when org-icalendar-verify-function
            (unless (funcall org-icalendar-verify-function)
              (outline-next-heading)
              (backward-char 1)
@@ -403,7 +403,7 @@ END:VEVENT\n"
        (while (re-search-forward org-todo-line-regexp nil t)
          (catch :skip
            (org-agenda-skip)
-           (when (boundp 'org-icalendar-verify-function)
+           (when org-icalendar-verify-function
              (unless (save-match-data
                        (funcall org-icalendar-verify-function))
                (outline-next-heading)

After that I have further problems with a nil org-todo-line regexp in:

 re-search-forward(nil nil t)                                                                                                                
  org-print-icalendar-entries(t) 

but I'm off to a meeting. I'll have a look later

    Andrew

-- 

____ Andrew Lawson ____
adl at absentis dot com

A notebook, a fountain pen, a good book for inspiration, a spot of tea
and an expansive view, could one ask for anything more?

Re: Bug in org-icalendar.el

[Carsten Dominik]

Applied, thanks.

- Carsten

On Nov 4, 2009, at 12:04 PM, Andrew Lawson wrote:

> Hi all
>    Just noticed an issue with a recent commit d51a8307 which defines
> org-icalendar-verify-function as nil but tests it using 'boundp. I'm
> using revision a7543733... The fix is:
>
> @@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
> line."
>       (while (re-search-forward re1 nil t)
>        (catch :skip
>          (org-agenda-skip)
> -         (when (boundp 'org-icalendar-verify-function)
> +         (when org-icalendar-verify-function
>            (unless (funcall org-icalendar-verify-function)
>              (outline-next-heading)
>              (backward-char 1)
> @@ -403,7 +403,7 @@ END:VEVENT\n"
>        (while (re-search-forward org-todo-line-regexp nil t)
>          (catch :skip
>            (org-agenda-skip)
> -           (when (boundp 'org-icalendar-verify-function)
> +           (when org-icalendar-verify-function
>              (unless (save-match-data
>                        (funcall org-icalendar-verify-function))
>                (outline-next-heading)
>
> After that I have further problems with a nil org-todo-line regexp in:
>
> re-search-forward(nil nil t)
>  org-print-icalendar-entries(t)
>
> but I'm off to a meeting. I'll have a look later
>
>    Andrew
>
> -- 
>
> ____ Andrew Lawson ____
> adl at absentis dot com
>
> A notebook, a fountain pen, a good book for inspiration, a spot of tea
> and an expansive view, could one ask for anything more?
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten