* Bug in org-icalendar.el
@ 2009-11-04 11:04 Andrew Lawson
2009-11-05 7:08 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lawson @ 2009-11-04 11:04 UTC (permalink / raw)
To: org-mode Mailinglist
Hi all
Just noticed an issue with a recent commit d51a8307 which defines
org-icalendar-verify-function as nil but tests it using 'boundp. I'm
using revision a7543733... The fix is:
@@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
line."
(while (re-search-forward re1 nil t)
(catch :skip
(org-agenda-skip)
- (when (boundp 'org-icalendar-verify-function)
+ (when org-icalendar-verify-function
(unless (funcall org-icalendar-verify-function)
(outline-next-heading)
(backward-char 1)
@@ -403,7 +403,7 @@ END:VEVENT\n"
(while (re-search-forward org-todo-line-regexp nil t)
(catch :skip
(org-agenda-skip)
- (when (boundp 'org-icalendar-verify-function)
+ (when org-icalendar-verify-function
(unless (save-match-data
(funcall org-icalendar-verify-function))
(outline-next-heading)
After that I have further problems with a nil org-todo-line regexp in:
re-search-forward(nil nil t)
org-print-icalendar-entries(t)
but I'm off to a meeting. I'll have a look later
Andrew
--
____ Andrew Lawson ____
adl at absentis dot com
A notebook, a fountain pen, a good book for inspiration, a spot of tea
and an expansive view, could one ask for anything more?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Bug in org-icalendar.el
2009-11-04 11:04 Bug in org-icalendar.el Andrew Lawson
@ 2009-11-05 7:08 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-11-05 7:08 UTC (permalink / raw)
To: Andrew Lawson; +Cc: org-mode Mailinglist
Applied, thanks.
- Carsten
On Nov 4, 2009, at 12:04 PM, Andrew Lawson wrote:
> Hi all
> Just noticed an issue with a recent commit d51a8307 which defines
> org-icalendar-verify-function as nil but tests it using 'boundp. I'm
> using revision a7543733... The fix is:
>
> @@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
> line."
> (while (re-search-forward re1 nil t)
> (catch :skip
> (org-agenda-skip)
> - (when (boundp 'org-icalendar-verify-function)
> + (when org-icalendar-verify-function
> (unless (funcall org-icalendar-verify-function)
> (outline-next-heading)
> (backward-char 1)
> @@ -403,7 +403,7 @@ END:VEVENT\n"
> (while (re-search-forward org-todo-line-regexp nil t)
> (catch :skip
> (org-agenda-skip)
> - (when (boundp 'org-icalendar-verify-function)
> + (when org-icalendar-verify-function
> (unless (save-match-data
> (funcall org-icalendar-verify-function))
> (outline-next-heading)
>
> After that I have further problems with a nil org-todo-line regexp in:
>
> re-search-forward(nil nil t)
> org-print-icalendar-entries(t)
>
> but I'm off to a meeting. I'll have a look later
>
> Andrew
>
> --
>
> ____ Andrew Lawson ____
> adl at absentis dot com
>
> A notebook, a fountain pen, a good book for inspiration, a spot of tea
> and an expansive view, could one ask for anything more?
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-05 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-04 11:04 Bug in org-icalendar.el Andrew Lawson
2009-11-05 7:08 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).