From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Bug in org-icalendar.el
Date: Thu, 5 Nov 2009 08:08:59 +0100
Message-ID: <8A171523-4260-4364-96CF-F8DDD227E4E1@gmail.com>
References: <20091104110457.GA18193@absentis.com>
Mime-Version: 1.0 (Apple Message framework v936)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N5wSy-0001y7-JN
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 02:09:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N5wSt-0001uN-Ht
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 02:09:07 -0500
Received: from [199.232.76.173] (port=45901 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N5wSt-0001u8-9e
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 02:09:03 -0500
Received: from mail-ew0-f228.google.com ([209.85.219.228]:55355)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <carsten.dominik@gmail.com>) id 1N5wSs-0004Jz-WB
	for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 02:09:03 -0500
Received: by ewy28 with SMTP id 28so843779ewy.42
	for <emacs-orgmode@gnu.org>; Wed, 04 Nov 2009 23:09:02 -0800 (PST)
In-Reply-To: <20091104110457.GA18193@absentis.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Andrew Lawson <adl@absentis.com>
Cc: org-mode Mailinglist <emacs-orgmode@gnu.org>

Applied, thanks.

- Carsten

On Nov 4, 2009, at 12:04 PM, Andrew Lawson wrote:

> Hi all
>    Just noticed an issue with a recent commit d51a8307 which defines
> org-icalendar-verify-function as nil but tests it using 'boundp. I'm
> using revision a7543733... The fix is:
>
> @@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
> line."
>       (while (re-search-forward re1 nil t)
>        (catch :skip
>          (org-agenda-skip)
> -         (when (boundp 'org-icalendar-verify-function)
> +         (when org-icalendar-verify-function
>            (unless (funcall org-icalendar-verify-function)
>              (outline-next-heading)
>              (backward-char 1)
> @@ -403,7 +403,7 @@ END:VEVENT\n"
>        (while (re-search-forward org-todo-line-regexp nil t)
>          (catch :skip
>            (org-agenda-skip)
> -           (when (boundp 'org-icalendar-verify-function)
> +           (when org-icalendar-verify-function
>              (unless (save-match-data
>                        (funcall org-icalendar-verify-function))
>                (outline-next-heading)
>
> After that I have further problems with a nil org-todo-line regexp in:
>
> re-search-forward(nil nil t)
>  org-print-icalendar-entries(t)
>
> but I'm off to a meeting. I'll have a look later
>
>    Andrew
>
> -- 
>
> ____ Andrew Lawson ____
> adl at absentis dot com
>
> A notebook, a fountain pen, a good book for inspiration, a spot of tea
> and an expansive view, could one ask for anything more?
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten