From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lawson Subject: Bug in org-icalendar.el Date: Wed, 4 Nov 2009 12:04:57 +0100 Message-ID: <20091104110457.GA18193@absentis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5dfq-0001Nq-QV for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 06:05:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5dfk-0001KK-Bc for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 06:05:08 -0500 Received: from [199.232.76.173] (port=42706 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5dfk-0001KF-0c for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 06:05:04 -0500 Received: from crow2.exxs.net ([213.202.244.8]:40552) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5dfj-0004Fw-6X for emacs-orgmode@gnu.org; Wed, 04 Nov 2009 06:05:03 -0500 Received: from dev252-l.research.ravenpack.com (88.Red-80-26-102.staticIP.rima-tde.net [80.26.102.88]) by crow2.exxs.net (Postfix) with SMTP id 822792428E0 for ; Wed, 4 Nov 2009 12:04:58 +0100 (CET) Content-Disposition: inline List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: org-mode Mailinglist Hi all Just noticed an issue with a recent commit d51a8307 which defines org-icalendar-verify-function as nil but tests it using 'boundp. I'm using revision a7543733... The fix is: @@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each line." (while (re-search-forward re1 nil t) (catch :skip (org-agenda-skip) - (when (boundp 'org-icalendar-verify-function) + (when org-icalendar-verify-function (unless (funcall org-icalendar-verify-function) (outline-next-heading) (backward-char 1) @@ -403,7 +403,7 @@ END:VEVENT\n" (while (re-search-forward org-todo-line-regexp nil t) (catch :skip (org-agenda-skip) - (when (boundp 'org-icalendar-verify-function) + (when org-icalendar-verify-function (unless (save-match-data (funcall org-icalendar-verify-function)) (outline-next-heading) After that I have further problems with a nil org-todo-line regexp in: re-search-forward(nil nil t) org-print-icalendar-entries(t) but I'm off to a meeting. I'll have a look later Andrew -- ____ Andrew Lawson ____ adl at absentis dot com A notebook, a fountain pen, a good book for inspiration, a spot of tea and an expansive view, could one ask for anything more?