[PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Kosyrev Serge]

* ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
to the list of valid task attributes
---
 contrib/lisp/ox-taskjuggler.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
index 2bd47e6..cfb28f2 100644
--- a/contrib/lisp/ox-taskjuggler.el
+++ b/contrib/lisp/ox-taskjuggler.el
@@ -301,7 +301,7 @@ but before any resource and task declarations."
   :type '(string :tag "Preamble"))
 
 (defcustom org-taskjuggler-valid-task-attributes
-  '(account start note duration endbuffer endcredit end
+  '(account depends start note duration endbuffer endcredit end
            flags journalentry length limits maxend maxstart minend
            minstart period reference responsible scheduling
            startbuffer startcredit statusnote chargeset charge)
-- 
2.5.0

Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Aaron Ecay]

Hi Kosyrev,

2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
> 
> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
> to the list of valid task attributes
> ---
>  contrib/lisp/ox-taskjuggler.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
> index 2bd47e6..cfb28f2 100644
> --- a/contrib/lisp/ox-taskjuggler.el
> +++ b/contrib/lisp/ox-taskjuggler.el
> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>    :type '(string :tag "Preamble"))
>  
>  (defcustom org-taskjuggler-valid-task-attributes

Is this an open-ended list that an average user could meaningfully add
to?  If not, perhaps it should be a defconst.  (I don’t know anything
about the taskjuggler format, so I’m sure whatever decision you make
will be OK.)

-- 
Aaron Ecay

Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Kosyrev Serge]

Aaron Ecay <aaronecay@gmail.com> writes:
> Hi Kosyrev,
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>>    :type '(string :tag "Preamble"))
>>  
>>  (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to?  If not, perhaps it should be a defconst.  (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)

Generally speaking, TaskJuggler own "attributes" and "properties" are
very numerous.  Suffice to point to the documentation:

  http://taskjuggler.org/tj3/manual/

Org is only able to provide a very limited amount of those, and the
approach it takes is by white-listing the properties that ought to
"pass through" from Org to TJP files.

So, naturally, whenever one faces a limitation in ox-taskjuggler,
the desire to extend the list arises.

I'm not sure how this relates to an average user, to be honest,
and whether I've at all helped with your question..

How do we proceed?

-- 
с уважениeм / respectfully,
Косырев Сергей

Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Aaron Ecay]

Hi Kosyrev,

2015ko azaroak 10an, Kosyrev Serge-ek idatzi zuen:
> 
> Generally speaking, TaskJuggler own "attributes" and "properties" are
> very numerous.  Suffice to point to the documentation:
> 
>   http://taskjuggler.org/tj3/manual/
> 
> Org is only able to provide a very limited amount of those, and the
> approach it takes is by white-listing the properties that ought to
> "pass through" from Org to TJP files.
> 
> So, naturally, whenever one faces a limitation in ox-taskjuggler,
> the desire to extend the list arises.
> 
> I'm not sure how this relates to an average user, to be honest,
> and whether I've at all helped with your question..
> 
> How do we proceed?

The difference between a defvar and a defcustom is whether the variable
shows up in M-x customize.  Customize often serves as the first port of
call for users discovering the features of a library.  So the question
is, will presenting users with such a list in the customize interface
empower them to have better taskjuggler export?  Or will it be too
intimidating?  It’s a subjective decision, I was just wondering whether
you had considered it.

Either way, it would be good to put the documentation link you gave into
the docstring, as a pointer to the allowed values of the variable.

Does that make sense?

-- 
Aaron Ecay

Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Rasmus]

Aaron Ecay <aaronecay@gmail.com> writes:

> Hi Kosyrev,
>
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>> 
>> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
>> to the list of valid task attributes
>> ---
>>  contrib/lisp/ox-taskjuggler.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 2bd47e6..cfb28f2 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>>    :type '(string :tag "Preamble"))
>>  
>>  (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to?  If not, perhaps it should be a defconst.  (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)

Would a user be able to meaningfully add something to the list?  Or does
each attribute need some lisp glue to be transformed from Org to the
taskjuggler format?  In case of the latter, it should be a defvar IMO.

Also, as suggested by Aaron it would be great if you could add pointers to
the taskjuggler documentation.

Thanks,
Rasmus

-- 
History is what should never happen again