* [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
@ 2015-11-08 10:12 Kosyrev Serge
2015-11-10 0:04 ` Aaron Ecay
0 siblings, 1 reply; 5+ messages in thread
From: Kosyrev Serge @ 2015-11-08 10:12 UTC (permalink / raw)
To: emacs-orgmode
* ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
to the list of valid task attributes
---
contrib/lisp/ox-taskjuggler.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
index 2bd47e6..cfb28f2 100644
--- a/contrib/lisp/ox-taskjuggler.el
+++ b/contrib/lisp/ox-taskjuggler.el
@@ -301,7 +301,7 @@ but before any resource and task declarations."
:type '(string :tag "Preamble"))
(defcustom org-taskjuggler-valid-task-attributes
- '(account start note duration endbuffer endcredit end
+ '(account depends start note duration endbuffer endcredit end
flags journalentry length limits maxend maxstart minend
minstart period reference responsible scheduling
startbuffer startcredit statusnote chargeset charge)
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
2015-11-08 10:12 [PATCH] ox-taskjuggler.el: allow direct 'depends' specification Kosyrev Serge
@ 2015-11-10 0:04 ` Aaron Ecay
2015-11-10 8:07 ` Kosyrev Serge
2015-11-12 16:36 ` Rasmus
0 siblings, 2 replies; 5+ messages in thread
From: Aaron Ecay @ 2015-11-10 0:04 UTC (permalink / raw)
To: Kosyrev Serge, emacs-orgmode
Hi Kosyrev,
2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>
> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
> to the list of valid task attributes
> ---
> contrib/lisp/ox-taskjuggler.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
> index 2bd47e6..cfb28f2 100644
> --- a/contrib/lisp/ox-taskjuggler.el
> +++ b/contrib/lisp/ox-taskjuggler.el
> @@ -301,7 +301,7 @@ but before any resource and task declarations."
> :type '(string :tag "Preamble"))
>
> (defcustom org-taskjuggler-valid-task-attributes
Is this an open-ended list that an average user could meaningfully add
to? If not, perhaps it should be a defconst. (I don’t know anything
about the taskjuggler format, so I’m sure whatever decision you make
will be OK.)
--
Aaron Ecay
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
2015-11-10 0:04 ` Aaron Ecay
@ 2015-11-10 8:07 ` Kosyrev Serge
2015-11-11 2:20 ` Aaron Ecay
2015-11-12 16:36 ` Rasmus
1 sibling, 1 reply; 5+ messages in thread
From: Kosyrev Serge @ 2015-11-10 8:07 UTC (permalink / raw)
To: Aaron Ecay; +Cc: emacs-orgmode
Aaron Ecay <aaronecay@gmail.com> writes:
> Hi Kosyrev,
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>> :type '(string :tag "Preamble"))
>>
>> (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to? If not, perhaps it should be a defconst. (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)
Generally speaking, TaskJuggler own "attributes" and "properties" are
very numerous. Suffice to point to the documentation:
http://taskjuggler.org/tj3/manual/
Org is only able to provide a very limited amount of those, and the
approach it takes is by white-listing the properties that ought to
"pass through" from Org to TJP files.
So, naturally, whenever one faces a limitation in ox-taskjuggler,
the desire to extend the list arises.
I'm not sure how this relates to an average user, to be honest,
and whether I've at all helped with your question..
How do we proceed?
--
с уважениeм / respectfully,
Косырев Сергей
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
2015-11-10 8:07 ` Kosyrev Serge
@ 2015-11-11 2:20 ` Aaron Ecay
0 siblings, 0 replies; 5+ messages in thread
From: Aaron Ecay @ 2015-11-11 2:20 UTC (permalink / raw)
To: Kosyrev Serge; +Cc: emacs-orgmode
Hi Kosyrev,
2015ko azaroak 10an, Kosyrev Serge-ek idatzi zuen:
>
> Generally speaking, TaskJuggler own "attributes" and "properties" are
> very numerous. Suffice to point to the documentation:
>
> http://taskjuggler.org/tj3/manual/
>
> Org is only able to provide a very limited amount of those, and the
> approach it takes is by white-listing the properties that ought to
> "pass through" from Org to TJP files.
>
> So, naturally, whenever one faces a limitation in ox-taskjuggler,
> the desire to extend the list arises.
>
> I'm not sure how this relates to an average user, to be honest,
> and whether I've at all helped with your question..
>
> How do we proceed?
The difference between a defvar and a defcustom is whether the variable
shows up in M-x customize. Customize often serves as the first port of
call for users discovering the features of a library. So the question
is, will presenting users with such a list in the customize interface
empower them to have better taskjuggler export? Or will it be too
intimidating? It’s a subjective decision, I was just wondering whether
you had considered it.
Either way, it would be good to put the documentation link you gave into
the docstring, as a pointer to the allowed values of the variable.
Does that make sense?
--
Aaron Ecay
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
2015-11-10 0:04 ` Aaron Ecay
2015-11-10 8:07 ` Kosyrev Serge
@ 2015-11-12 16:36 ` Rasmus
1 sibling, 0 replies; 5+ messages in thread
From: Rasmus @ 2015-11-12 16:36 UTC (permalink / raw)
To: emacs-orgmode
Aaron Ecay <aaronecay@gmail.com> writes:
> Hi Kosyrev,
>
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>>
>> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
>> to the list of valid task attributes
>> ---
>> contrib/lisp/ox-taskjuggler.el | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 2bd47e6..cfb28f2 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>> :type '(string :tag "Preamble"))
>>
>> (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to? If not, perhaps it should be a defconst. (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)
Would a user be able to meaningfully add something to the list? Or does
each attribute need some lisp glue to be transformed from Org to the
taskjuggler format? In case of the latter, it should be a defvar IMO.
Also, as suggested by Aaron it would be great if you could add pointers to
the taskjuggler documentation.
Thanks,
Rasmus
--
History is what should never happen again
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-12 16:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-08 10:12 [PATCH] ox-taskjuggler.el: allow direct 'depends' specification Kosyrev Serge
2015-11-10 0:04 ` Aaron Ecay
2015-11-10 8:07 ` Kosyrev Serge
2015-11-11 2:20 ` Aaron Ecay
2015-11-12 16:36 ` Rasmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).