emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification
Date: Thu, 12 Nov 2015 17:36:43 +0100	[thread overview]
Message-ID: <874mgrkwdg.fsf@gmx.us> (raw)
In-Reply-To: 87egfysorn.fsf@gmail.com

Aaron Ecay <aaronecay@gmail.com> writes:

> Hi Kosyrev,
>
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>> 
>> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
>> to the list of valid task attributes
>> ---
>>  contrib/lisp/ox-taskjuggler.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 2bd47e6..cfb28f2 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>>    :type '(string :tag "Preamble"))
>>  
>>  (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to?  If not, perhaps it should be a defconst.  (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)

Would a user be able to meaningfully add something to the list?  Or does
each attribute need some lisp glue to be transformed from Org to the
taskjuggler format?  In case of the latter, it should be a defvar IMO.

Also, as suggested by Aaron it would be great if you could add pointers to
the taskjuggler documentation.

Thanks,
Rasmus

-- 
History is what should never happen again

     prev parent reply	other threads:[~2015-11-12 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08 10:12 [PATCH] ox-taskjuggler.el: allow direct 'depends' specification Kosyrev Serge
2015-11-10  0:04 ` Aaron Ecay
2015-11-10  8:07   ` Kosyrev Serge
2015-11-11  2:20     ` Aaron Ecay
2015-11-12 16:36   ` Rasmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mgrkwdg.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).