emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* latest org-attach.el change (commit "4939b4175") invalid download sub-command
@ 2019-06-21  5:49 stardiviner
  2019-06-21 22:27 ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: stardiviner @ 2019-06-21  5:49 UTC (permalink / raw)
  To: Org Mode


This latest org-attach.el change (commit "4939b4175") make some command like
=org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
confirmed.

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: latest org-attach.el change (commit "4939b4175") invalid download sub-command
  2019-06-21  5:49 latest org-attach.el change (commit "4939b4175") invalid download sub-command stardiviner
@ 2019-06-21 22:27 ` Kyle Meyer
  2019-06-24  7:13   ` stardiviner
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2019-06-21 22:27 UTC (permalink / raw)
  To: numbchild, Org Mode

stardiviner <numbchild@gmail.com> writes:

> This latest org-attach.el change (commit "4939b4175")

That commit didn't touch org-attach.el, but it's the parent of 72124726a
(org-attach: Make dispatcher commands customizable, 2019-04-26), which
did.  That seems to be the actual culprit.

> make some command like
> =org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
> confirmed.

The issue with org-attach-url should be fixed with 8e7280896.  You say
"some command like".  Did you run into similar issues with other
commands in the attach dispatcher?  org-attach-url looked to be the only
problematic one.  org-attach-attach-{cp,mv,ln,lns} all do the proper
let-binding of org-attach-method.

-- 
Kyle

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: latest org-attach.el change (commit "4939b4175") invalid download sub-command
  2019-06-21 22:27 ` Kyle Meyer
@ 2019-06-24  7:13   ` stardiviner
  0 siblings, 0 replies; 3+ messages in thread
From: stardiviner @ 2019-06-24  7:13 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Org Mode


Kyle Meyer <kyle@kyleam.com> writes:

> stardiviner <numbchild@gmail.com> writes:
>
>> This latest org-attach.el change (commit "4939b4175")
>
> That commit didn't touch org-attach.el, but it's the parent of 72124726a
> (org-attach: Make dispatcher commands customizable, 2019-04-26), which
> did.  That seems to be the actual culprit.
>
>> make some command like
>> =org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
>> confirmed.
>
> The issue with org-attach-url should be fixed with 8e7280896.  You say
> "some command like".  Did you run into similar issues with other
> commands in the attach dispatcher?  org-attach-url looked to be the only
> problematic one.  org-attach-attach-{cp,mv,ln,lns} all do the proper
> let-binding of org-attach-method.

Yes, I checked out the fix. It works for URL. And other commands works fine. Thanks :)

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-24  7:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-21  5:49 latest org-attach.el change (commit "4939b4175") invalid download sub-command stardiviner
2019-06-21 22:27 ` Kyle Meyer
2019-06-24  7:13   ` stardiviner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).