From mboxrd@z Thu Jan  1 00:00:00 1970
From: stardiviner <numbchild@gmail.com>
Subject: Re: latest org-attach.el change (commit "4939b4175") invalid
 download sub-command
Date: Mon, 24 Jun 2019 15:13:50 +0800
Message-ID: <87tvcfzc9d.fsf@gmail.com>
References: <87h88jmqsb.fsf@gmail.com> <87o92qr2ug.fsf@kyleam.com>
Reply-To: numbchild@gmail.com
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53670)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <numbchild@gmail.com>) id 1hfJKZ-0007F4-Tn
 for emacs-orgmode@gnu.org; Mon, 24 Jun 2019 03:24:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <numbchild@gmail.com>) id 1hfJKY-00059u-Ur
 for emacs-orgmode@gnu.org; Mon, 24 Jun 2019 03:23:59 -0400
Received: from [122.236.10.119] (port=45300 helo=dark.localdomain)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <numbchild@gmail.com>) id 1hfJKY-00058T-GC
 for emacs-orgmode@gnu.org; Mon, 24 Jun 2019 03:23:58 -0400
In-reply-to: <87o92qr2ug.fsf@kyleam.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org Mode <emacs-orgmode@gnu.org>


Kyle Meyer <kyle@kyleam.com> writes:

> stardiviner <numbchild@gmail.com> writes:
>
>> This latest org-attach.el change (commit "4939b4175")
>
> That commit didn't touch org-attach.el, but it's the parent of 72124726a
> (org-attach: Make dispatcher commands customizable, 2019-04-26), which
> did.  That seems to be the actual culprit.
>
>> make some command like
>> =org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
>> confirmed.
>
> The issue with org-attach-url should be fixed with 8e7280896.  You say
> "some command like".  Did you run into similar issues with other
> commands in the attach dispatcher?  org-attach-url looked to be the only
> problematic one.  org-attach-attach-{cp,mv,ln,lns} all do the proper
> let-binding of org-attach-method.

Yes, I checked out the fix. It works for URL. And other commands works fine. Thanks :)

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3