From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: latest org-attach.el change (commit "4939b4175") invalid
 download sub-command
Date: Fri, 21 Jun 2019 18:27:35 -0400
Message-ID: <87o92qr2ug.fsf@kyleam.com>
References: <87h88jmqsb.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56286)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <kyle@kyleam.com>) id 1heS0l-00058N-GO
 for emacs-orgmode@gnu.org; Fri, 21 Jun 2019 18:28:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kyle@kyleam.com>) id 1heS0j-0006HD-94
 for emacs-orgmode@gnu.org; Fri, 21 Jun 2019 18:27:58 -0400
Received: from pb-smtp20.pobox.com ([173.228.157.52]:55397)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1heS0h-00060A-3I
 for emacs-orgmode@gnu.org; Fri, 21 Jun 2019 18:27:56 -0400
In-Reply-To: <87h88jmqsb.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: numbchild@gmail.com, Org Mode <emacs-orgmode@gnu.org>

stardiviner <numbchild@gmail.com> writes:

> This latest org-attach.el change (commit "4939b4175")

That commit didn't touch org-attach.el, but it's the parent of 72124726a
(org-attach: Make dispatcher commands customizable, 2019-04-26), which
did.  That seems to be the actual culprit.

> make some command like
> =org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
> confirmed.

The issue with org-attach-url should be fixed with 8e7280896.  You say
"some command like".  Did you run into similar issues with other
commands in the attach dispatcher?  org-attach-url looked to be the only
problematic one.  org-attach-attach-{cp,mv,ln,lns} all do the proper
let-binding of org-attach-method.

-- 
Kyle