From: stardiviner <numbchild@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: latest org-attach.el change (commit "4939b4175") invalid download sub-command
Date: Mon, 24 Jun 2019 15:13:50 +0800 [thread overview]
Message-ID: <87tvcfzc9d.fsf@gmail.com> (raw)
In-Reply-To: <87o92qr2ug.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> stardiviner <numbchild@gmail.com> writes:
>
>> This latest org-attach.el change (commit "4939b4175")
>
> That commit didn't touch org-attach.el, but it's the parent of 72124726a
> (org-attach: Make dispatcher commands customizable, 2019-04-26), which
> did. That seems to be the actual culprit.
>
>> make some command like
>> =org-attach= + =[u]= for downloading is invalid. I git check out before this commit,
>> confirmed.
>
> The issue with org-attach-url should be fixed with 8e7280896. You say
> "some command like". Did you run into similar issues with other
> commands in the attach dispatcher? org-attach-url looked to be the only
> problematic one. org-attach-attach-{cp,mv,ln,lns} all do the proper
> let-binding of org-attach-method.
Yes, I checked out the fix. It works for URL. And other commands works fine. Thanks :)
--
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
prev parent reply other threads:[~2019-06-24 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 5:49 latest org-attach.el change (commit "4939b4175") invalid download sub-command stardiviner
2019-06-21 22:27 ` Kyle Meyer
2019-06-24 7:13 ` stardiviner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvcfzc9d.fsf@gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).