From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: CVE-2023-28617 (was Re: [PATCH] Fix ob-latex.el command injection vulnerability.)
Date: Fri, 12 May 2023 13:42:30 +0000 [thread overview]
Message-ID: <87r0rlzmwp.fsf@localhost> (raw)
In-Reply-To: <u3j374$6v7$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
>> But this patch literally fixed the problem. What else should we do?
>
> Do you really think that it was the last unsafe shell command in the Org
> code?
No, but I prefer concrete examples. The CVE you linked to refers to
an already fixed bug.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ob-ditaa.el#n101
> and (shell-command pdf-cmd) below
The only unsafe part there is `java' that is taken from :java header
argument. I am unsure how to fix this issue without feature regression.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ob-lilypond.el#n194
May you provide a patch?
>>> I suppose, the issue has been received too much attention already:
>>>
>>> - https://security-tracker.debian.org/tracker/CVE-2023-28617
>>> - https://ubuntu.com/security/notices/USN-6003-1
>>> - https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2023-28617
>>
>> These appear to be different issues.
>
> Linux distributions had to react to the CVE with formally high score and
> updated Emacs packages applying 2 tiny patches from this thread.
Sure, but I have applied both the patches onto bugfix. That's why I
asked you what else we should do.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-05-12 13:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 10:08 [PATCH] Fix ob-latex.el command injection vulnerability lux
2023-02-18 11:15 ` Max Nikulin
2023-02-18 11:28 ` lux
2023-02-18 11:43 ` Ihor Radchenko
2023-02-19 2:31 ` lux
2023-03-06 3:17 ` lux
2023-03-07 12:35 ` Ihor Radchenko
2023-03-07 13:20 ` lux
2023-03-07 13:52 ` Ihor Radchenko
2023-03-07 15:06 ` Bastien Guerry
2023-03-07 15:10 ` Ihor Radchenko
2023-03-07 15:31 ` Max Nikulin
2023-03-08 2:28 ` lux
2023-03-08 15:42 ` lux
2023-03-09 12:22 ` Ihor Radchenko
2023-03-09 16:29 ` Max Nikulin
2023-03-11 5:12 ` lux
2023-03-11 10:47 ` Ihor Radchenko
2023-03-11 10:57 ` lux
2023-03-12 11:28 ` Ihor Radchenko
2023-05-01 10:56 ` Max Nikulin
2023-05-01 11:18 ` Ihor Radchenko
2023-05-02 11:02 ` CVE-2023-28617 (was Re: [PATCH] Fix ob-latex.el command injection vulnerability.) Max Nikulin
2023-05-02 11:21 ` Ihor Radchenko
2023-05-11 15:56 ` Max Nikulin
2023-05-12 13:42 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0rlzmwp.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).