emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ob-latex.el command injection vulnerability.
Date: Thu, 9 Mar 2023 23:29:41 +0700	[thread overview]
Message-ID: <tud1hn$hnj$1@ciao.gmane.io> (raw)
In-Reply-To: <871qlyqfm0.fsf@localhost>

On 09/03/2023 19:22, Ihor Radchenko wrote:
> lux writes:
>> Hi, this is a new patch, let me briefly explain this patch:

Thank you for scratching my itch related to unsafe shell commands in Org 
Mode.

>> 2. `org-babel-latex-convert-pdf' is not safe, simple test:
...
> I am not sure if blindly adding `shell-quote-argument' is safe here.

I believe, first hunk still can be committed.

>>       (shell-command cmd)))
> 
> im-in-options and im-out-options, according to
> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-LaTeX.html,
> are options passed to ImageMagick.

ImageMagick is disaster per se.

Ideally `call-process' or `process-file' should be here instead of 
`shell-command' making `shell-quote-argument' unnecessary. Sorry, it is 
not clear for me if remote files (e.g. /ssh:...) are supported here. 
Unfortunately options as a string, not as a list, means compatibility 
issue. `split-string-and-unquote' may cause new bugs.

I have not evaluated it yet, but from discussions on this list I have an 
impression that some LaTeX packages need to run external commands. I am 
unsure to which degree it is safe or it may be easily exploited.



  reply	other threads:[~2023-03-09 16:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 10:08 [PATCH] Fix ob-latex.el command injection vulnerability lux
2023-02-18 11:15 ` Max Nikulin
2023-02-18 11:28   ` lux
2023-02-18 11:43     ` Ihor Radchenko
2023-02-19  2:31       ` lux
2023-03-06  3:17       ` lux
2023-03-07 12:35         ` Ihor Radchenko
2023-03-07 13:20           ` lux
2023-03-07 13:52             ` Ihor Radchenko
2023-03-07 15:06               ` Bastien Guerry
2023-03-07 15:10                 ` Ihor Radchenko
2023-03-07 15:31         ` Max Nikulin
2023-03-08  2:28           ` lux
2023-03-08 15:42           ` lux
2023-03-09 12:22             ` Ihor Radchenko
2023-03-09 16:29               ` Max Nikulin [this message]
2023-03-11  5:12               ` lux
2023-03-11 10:47                 ` Ihor Radchenko
2023-03-11 10:57                   ` lux
2023-03-12 11:28                     ` Ihor Radchenko
2023-05-01 10:56                       ` Max Nikulin
2023-05-01 11:18                         ` Ihor Radchenko
2023-05-02 11:02                           ` CVE-2023-28617 (was Re: [PATCH] Fix ob-latex.el command injection vulnerability.) Max Nikulin
2023-05-02 11:21                             ` Ihor Radchenko
2023-05-11 15:56                               ` Max Nikulin
2023-05-12 13:42                                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tud1hn$hnj$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).