From: Max Nikulin <manikulin@gmail.com>
To: lux <lx@shellcodes.org>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ob-latex.el command injection vulnerability.
Date: Sat, 18 Feb 2023 18:15:48 +0700 [thread overview]
Message-ID: <ea686f70-3cf7-e9cd-1663-c065af08ae03@gmail.com> (raw)
In-Reply-To: <tencent_7B48D6A8D4FCDC2DC8DF842B069B715ECE0A@qq.com>
On 18/02/2023 17:08, lux wrote:
> - (shell-command (format "mv %s %s" img-out out-file)))))
> + (shell-command (format "mv %s %s" (shell-quote-argument img-out) (shell-quote-argument out-file))))))
Thank you for the patch. Certainly it is an improvement.
Is there any reason why `rename-file' should be avoided here? I just
have discovered this function, so I am unaware of possible pitfalls.
(info "(elisp) Changing-Files")
https://www.gnu.org/software/emacs/manual/html_node/elisp/Changing-Files.html#index-rename_002dfile
next prev parent reply other threads:[~2023-02-18 11:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 10:08 [PATCH] Fix ob-latex.el command injection vulnerability lux
2023-02-18 11:15 ` Max Nikulin [this message]
2023-02-18 11:28 ` lux
2023-02-18 11:43 ` Ihor Radchenko
2023-02-19 2:31 ` lux
2023-03-06 3:17 ` lux
2023-03-07 12:35 ` Ihor Radchenko
2023-03-07 13:20 ` lux
2023-03-07 13:52 ` Ihor Radchenko
2023-03-07 15:06 ` Bastien Guerry
2023-03-07 15:10 ` Ihor Radchenko
2023-03-07 15:31 ` Max Nikulin
2023-03-08 2:28 ` lux
2023-03-08 15:42 ` lux
2023-03-09 12:22 ` Ihor Radchenko
2023-03-09 16:29 ` Max Nikulin
2023-03-11 5:12 ` lux
2023-03-11 10:47 ` Ihor Radchenko
2023-03-11 10:57 ` lux
2023-03-12 11:28 ` Ihor Radchenko
2023-05-01 10:56 ` Max Nikulin
2023-05-01 11:18 ` Ihor Radchenko
2023-05-02 11:02 ` CVE-2023-28617 (was Re: [PATCH] Fix ob-latex.el command injection vulnerability.) Max Nikulin
2023-05-02 11:21 ` Ihor Radchenko
2023-05-11 15:56 ` Max Nikulin
2023-05-12 13:42 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea686f70-3cf7-e9cd-1663-c065af08ae03@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=lx@shellcodes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).