[PATCH] Proposed command: org-agenda-clock-goto

[PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

From the agenda, I often want to jump to the currently clocking task
without leaving the agenda buffer.

The attached patch contains a function that does so.

Would that be useful to anyone else?

If so, any suggestion for a keybinding?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-agenda.el.patch --]
[-- Type: text/x-patch, Size: 731 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index d62b193..bba8683 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2806,6 +2806,16 @@ the global options and expect it to be applied to the entire view.")
 	(org-agenda-filter-apply org-agenda-filter))
       )))
 
+(defun org-agenda-clock-goto ()
+  "Jump to the currently clocked in task within the agenda."
+  (interactive)
+  (let (pos)
+    (mapc (lambda (o)
+	    (if (eq (overlay-get o 'type) 'org-agenda-clocking)
+		(setq pos (overlay-start o))))
+	  (overlays-in (point-min) (point-max)))
+    (if pos (goto-char pos))))
+
 (defun org-agenda-mark-clocking-task ()
   "Mark the current clock entry in the agenda if it is present."
   (mapc (lambda (o)

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Bastien <bastien.guerry@wikimedia.fr> writes:

>From the agenda, I often want to jump to the currently clocking task
> without leaving the agenda buffer.
>
> The attached patch contains a function that does so.
>
> Would that be useful to anyone else?
>
> If so, any suggestion for a keybinding?

I'm thinking of using "J" as a keybinding for the following command 
in the agenda buffer:

--8<---------------cut here---------------start------------->8---
(defun org-agenda-clock-goto ()
  "Jump to the currently clocked in task within the agenda."
  (interactive)
  (let (pos)
    (mapc (lambda (o)
	    (if (eq (overlay-get o 'type) 'org-agenda-clocking)
		(setq pos (overlay-start o))))
	  (overlays-in (point-min) (point-max)))
    (if pos (goto-char pos))))
--8<---------------cut here---------------end--------------->8---

For now `J' and `C-c C-x C-j' do the same thing: they jump to the
location of the current/last running clock.

After this change `J' would jump on the entry in the agenda buffer 
while `C-c C-x C-j' would jump to the entry itself.

Does that break anyone habit?

-- 
 Bastien

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Noorul Islam]

[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

On Sun, Aug 1, 2010 at 1:27 PM, Bastien <bastien.guerry@wikimedia.fr> wrote:

> From the agenda, I often want to jump to the currently clocking task
> without leaving the agenda buffer.
>
> The attached patch contains a function that does so.
>
> Would that be useful to anyone else?
>
> If so, any suggestion for a keybinding?
>
>
This will be really helpful. I always find it hard doing it by moving
cursor.

Thanks
Noorul

[-- Attachment #1.2: Type: text/html, Size: 758 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Noorul Islam <noorul@noorul.com> writes:

>     >From the agenda, I often want to jump to the currently clocking task
>     without leaving the agenda buffer.
>    
>     The attached patch contains a function that does so.
>    
>     Would that be useful to anyone else?
>    
>     If so, any suggestion for a keybinding?
>
> This will be really helpful. I always find it hard doing it by moving
> cursor.

I pushed a change for this in the git repo.

You can use `C-c C-x C-j' to jump to the headline of the cloking task,
and use `J' to jump to the entry itself (just as before).

If some people are used to use `C-c C-x C-j' to jump to the entry,
please amend your habits a bit and use `J' instead...

Thanks,

-- 
 Bastien

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bernt Hansen]

Noorul Islam <noorul@noorul.com> writes:

> On Sun, Aug 1, 2010 at 1:27 PM, Bastien <bastien.guerry@wikimedia.fr> wrote:
>
>     From the agenda, I often want to jump to the currently clocking task
>     without leaving the agenda buffer.
>    
>     The attached patch contains a function that does so.
>    
>     Would that be useful to anyone else?
>    
>     If so, any suggestion for a keybinding?
>
> This will be really helpful. I always find it hard doing it by moving cursor.

I'm in the other camp.  I've never needed or used the jump to agenda
functionality.  I always use org-clock-goto to get to the org file of
the current clocking task.  Often my agenda view does not include the
current clocking task due to filters - so jumping to it in the agenda
won't work anyway for me.

I'm not against this change since I've never used J in the agenda before
(mostly because I wasn't aware of this key binding at all).

Is there a way to rebind agenda keys in case I want to use J for
something different (similar to the user speed key settings?)  I don't
really want to overwrite the standard org-agenda-keymap bindings but it
might be useful to have user bindings that on top of those as we do for
the speed key settings.

-Bernt

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Bernt Hansen <bernt@norang.ca> writes:

> I'm not against this change since I've never used J in the agenda before
> (mostly because I wasn't aware of this key binding at all).

C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers and
to org-clock-goto is org buffers.

I hesitated long, and I'm still not convinved this is the best choice.

Since `J' is an agenda-only keybinding, maybe using `J' would make more
sense.

What's your take on this?

> Is there a way to rebind agenda keys in case I want to use J for
> something different (similar to the user speed key settings?)  

(org-defkey org-agenda-mode-map "J" 'your-function)

> I don't really want to overwrite the standard org-agenda-keymap
> bindings but it might be useful to have user bindings that on top of
> those as we do for the speed key settings.

...

Mayby, if rebinding agenda keys is common.  I personaly don't rebind
agenda keys.

HTH,

-- 
 Bastien

Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bernt Hansen]

Bastien <bastien.guerry@wikimedia.fr> writes:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> I'm not against this change since I've never used J in the agenda before
>> (mostly because I wasn't aware of this key binding at all).
>
> C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers and
> to org-clock-goto is org buffers.
>
> I hesitated long, and I'm still not convinved this is the best choice.
>
> Since `J' is an agenda-only keybinding, maybe using `J' would make more
> sense.
>
> What's your take on this?

I currently have a binding for F11 that calls org-clock-goto so I'm
unlikely to switch to using J -- mainly because F11 works everywhere for
me and J only works in the agenda and on org-mode headings.

>
>> Is there a way to rebind agenda keys in case I want to use J for
>> something different (similar to the user speed key settings?)  
>
> (org-defkey org-agenda-mode-map "J" 'your-function)

Thanks

>
>> I don't really want to overwrite the standard org-agenda-keymap
>> bindings but it might be useful to have user bindings that on top of
>> those as we do for the speed key settings.
>
> ...
>
> Mayby, if rebinding agenda keys is common.  I personaly don't rebind
> agenda keys.

I currently don't rebind agenda keys -- I was just thinking if we're
changing keys and people want their own definitions this might be
useful.  I'd skip implementing this until there's a real benefit from
it.

Regards,
Bernt

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Carsten Dominik]

On Aug 7, 2010, at 10:14 AM, Bastien wrote:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> I'm not against this change since I've never used J in the agenda  
>> before
>> (mostly because I wasn't aware of this key binding at all).
>
> C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers  
> and
> to org-clock-goto is org buffers.
>
> I hesitated long, and I'm still not convinved this is the best choice.
>
> Since `J' is an agenda-only keybinding, maybe using `J' would make  
> more
> sense.

I have not looked up which way it is now,
but thinking again it seems to me that this would be the right way:

C-c C-x C-j jumps to the entry in the org buffer, both from the agenda
and from normal buffers.

"J" would then be available to find the clock entry in the agenda, if
it is present there.  We could extend this command to show the clock
entry in the other window if the line cannot be found in the agenda
window...

- Carsten

>
> What's your take on this?
>
>> Is there a way to rebind agenda keys in case I want to use J for
>> something different (similar to the user speed key settings?)
>
> (org-defkey org-agenda-mode-map "J" 'your-function)


In general, he best way to do user keys is to bind them in the
mode hook of the mode you need them for, in this
case org-agenda-mode-hook.

>
>> I don't really want to overwrite the standard org-agenda-keymap
>> bindings but it might be useful to have user bindings that on top of
>> those as we do for the speed key settings.

I think doing the hook think is good enough for this case.
The speed key implementation is different.

- Carsten

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> I have not looked up which way it is now,
> but thinking again it seems to me that this would be the right way:
>
> C-c C-x C-j jumps to the entry in the org buffer, both from the agenda
> and from normal buffers.

This is how it works now.  I updated the doc accordingly and I also
added a line for the `J' command in the agenda buffer.

> "J" would then be available to find the clock entry in the agenda, if
> it is present there.  We could extend this command to show the clock
> entry in the other window if the line cannot be found in the agenda
> window...

This is how it works - please let me know if it works okay.

Thanks,

-- 
 Bastien

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Carsten Dominik]

On Aug 11, 2010, at 4:24 PM, Bastien wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> I have not looked up which way it is now,
>> but thinking again it seems to me that this would be the right way:
>>
>> C-c C-x C-j jumps to the entry in the org buffer, both from the  
>> agenda
>> and from normal buffers.
>
> This is how it works now.  I updated the doc accordingly and I also
> added a line for the `J' command in the agenda buffer.
>
>> "J" would then be available to find the clock entry in the agenda, if
>> it is present there.  We could extend this command to show the clock
>> entry in the other window if the line cannot be found in the agenda
>> window...
>
> This is how it works - please let me know if it works okay.


Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x C- 
j goes to the agenda lines corresponding to the clocking item.  I  
meant it the other way around.....  What am I missing?

- Carsten

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x C-
> j goes to the agenda lines corresponding to the clocking item.  I meant
> it the other way around.....  What am I missing?

Weird -- M-x org-reload?  This diff shows the change in the keybindinds:

  http://repo.or.cz/w/org-mode.git/blobdiff/f0be9ff91bd52c530f0d7556872576eb9803cb38..a7a842457dd927df9eabc756c4c573720a3a7aa9:/lisp/org-agenda.el

Let me know,

-- 
 Bastien

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Noorul Islam K M]

On Aug 12, 2010, at 3:43 AM, Bastien <bastien.guerry@wikimedia.fr> wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
> 
>> Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x C-
>> j goes to the agenda lines corresponding to the clocking item.  I meant
>> it the other way around.....  What am I missing?
> 
> Weird -- M-x org-reload?  This diff shows the change in the keybindinds:
> 
>  http://repo.or.cz/w/org-mode.git/blobdiff/f0be9ff91bd52c530f0d7556872576eb9803cb38..a7a842457dd927df9eabc756c4c573720a3a7aa9:/lisp/org-agenda.el
> 
> Let me know,

For me J takes me to the org file entry not to the agenda entry.

Thanks
Noorul

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bastien]

Noorul Islam K M <noorul@noorul.com> writes:

> For me J takes me to the org file entry not to the agenda entry.

That's weird.  Did you pull and get the last Org?

`J' should:

- move the point to the clocked in entry in the agenda buffer
- if the clocked entry is not listed in the agenda buffer, 
  display it in another window
- if there is no running clock, display a message.

I just pushed an updated docstring.  Works here...

-- 
 Bastien

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Carsten Dominik]

On Aug 12, 2010, at 12:13 AM, Bastien wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x  
>> C-
>> j goes to the agenda lines corresponding to the clocking item.  I  
>> meant
>> it the other way around.....  What am I missing?
>
> Weird -- M-x org-reload?  This diff shows the change in the  
> keybindinds:

You are right -it does not work for me.  Must have made a mistake.

Thanks!

- Carsten

Re: Proposed command: org-agenda-clock-goto

[Noorul Islam K M]

Bastien <bastien.guerry@wikimedia.fr> writes:

> Noorul Islam K M <noorul@noorul.com> writes:
>
>> For me J takes me to the org file entry not to the agenda entry.
>
> That's weird.  Did you pull and get the last Org?
>
> `J' should:
>
> - move the point to the clocked in entry in the agenda buffer
> - if the clocked entry is not listed in the agenda buffer, 
>   display it in another window
> - if there is no running clock, display a message.
>
Oh my bad! It actually works!

git pull
make clean
make

M-x org-reload

I am sorry about this spam.

I have been looking for this functionality for a long time. Thanks a
ton for this.

Thanks and Regards
Noorul

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Bernt Hansen]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Aug 12, 2010, at 12:13 AM, Bastien wrote:
>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x 
>>> C-
>>> j goes to the agenda lines corresponding to the clocking item.  I
>>> meant
>>> it the other way around.....  What am I missing?
>>
>> Weird -- M-x org-reload?  This diff shows the change in the
>> keybindinds:
>
> You are right -it does not work for me.  Must have made a mistake.

It works for me.

-Bernt

Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Carsten Dominik]

On Aug 12, 2010, at 1:23 PM, Bernt Hansen wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Aug 12, 2010, at 12:13 AM, Bastien wrote:
>>
>>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>>
>>>> Hmmm, I just pulled, and J jumps to the org-mode file while C-c C-x
>>>> C-
>>>> j goes to the agenda lines corresponding to the clocking item.  I
>>>> meant
>>>> it the other way around.....  What am I missing?
>>>
>>> Weird -- M-x org-reload?  This diff shows the change in the
>>> keybindinds:
>>
>> You are right -it does not work for me.  Must have made a mistake.

not -> now!

:(

>
> It works for me.
>
> -Bernt

- Carsten