From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bastien <bastien.guerry@wikimedia.fr>
Cc: Bernt Hansen <bernt@norang.ca>,
emacs-orgmode@gnu.org, Noorul Islam <noorul@noorul.com>
Subject: Re: Re: [PATCH] Proposed command: org-agenda-clock-goto
Date: Mon, 9 Aug 2010 08:50:15 +0200 [thread overview]
Message-ID: <3CCB0801-D852-4D40-A5B0-3135B2BCA708@gmail.com> (raw)
In-Reply-To: <87lj8ikffv.fsf@gnu.org>
On Aug 7, 2010, at 10:14 AM, Bastien wrote:
> Bernt Hansen <bernt@norang.ca> writes:
>
>> I'm not against this change since I've never used J in the agenda
>> before
>> (mostly because I wasn't aware of this key binding at all).
>
> C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers
> and
> to org-clock-goto is org buffers.
>
> I hesitated long, and I'm still not convinved this is the best choice.
>
> Since `J' is an agenda-only keybinding, maybe using `J' would make
> more
> sense.
I have not looked up which way it is now,
but thinking again it seems to me that this would be the right way:
C-c C-x C-j jumps to the entry in the org buffer, both from the agenda
and from normal buffers.
"J" would then be available to find the clock entry in the agenda, if
it is present there. We could extend this command to show the clock
entry in the other window if the line cannot be found in the agenda
window...
- Carsten
>
> What's your take on this?
>
>> Is there a way to rebind agenda keys in case I want to use J for
>> something different (similar to the user speed key settings?)
>
> (org-defkey org-agenda-mode-map "J" 'your-function)
In general, he best way to do user keys is to bind them in the
mode hook of the mode you need them for, in this
case org-agenda-mode-hook.
>
>> I don't really want to overwrite the standard org-agenda-keymap
>> bindings but it might be useful to have user bindings that on top of
>> those as we do for the speed key settings.
I think doing the hook think is good enough for this case.
The speed key implementation is different.
- Carsten
next prev parent reply other threads:[~2010-08-09 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 7:57 [PATCH] Proposed command: org-agenda-clock-goto Bastien
2010-08-04 9:54 ` Bastien
2010-08-06 14:52 ` Noorul Islam
2010-08-06 17:38 ` Bastien
2010-08-06 17:54 ` Bernt Hansen
2010-08-07 8:14 ` Bastien
2010-08-07 13:22 ` Bernt Hansen
2010-08-09 6:50 ` Carsten Dominik [this message]
2010-08-11 14:24 ` Bastien
2010-08-11 22:04 ` Carsten Dominik
2010-08-11 22:13 ` Bastien
2010-08-12 3:15 ` Noorul Islam K M
2010-08-12 8:30 ` Bastien
2010-08-12 10:26 ` Noorul Islam K M
2010-08-12 9:57 ` Re: [PATCH] " Carsten Dominik
2010-08-12 11:23 ` Bernt Hansen
2010-08-12 11:34 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CCB0801-D852-4D40-A5B0-3135B2BCA708@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bastien.guerry@wikimedia.fr \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=noorul@noorul.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).