From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: [PATCH] Proposed command: org-agenda-clock-goto Date: Mon, 9 Aug 2010 08:50:15 +0200 Message-ID: <3CCB0801-D852-4D40-A5B0-3135B2BCA708@gmail.com> References: <87pqy29344.fsf@gnu.org> <87pqxvd3u5.fsf@gollum.intra.norang.ca> <87lj8ikffv.fsf@gnu.org> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=53363 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiMer-0001as-Ru for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 03:20:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiMep-0005rH-M5 for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 03:20:29 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:36787) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiMep-0005r7-Hg for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 03:20:27 -0400 Received: by eydd26 with SMTP id d26so3640908eyd.0 for ; Mon, 09 Aug 2010 00:20:26 -0700 (PDT) In-Reply-To: <87lj8ikffv.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Bernt Hansen , emacs-orgmode@gnu.org, Noorul Islam On Aug 7, 2010, at 10:14 AM, Bastien wrote: > Bernt Hansen writes: > >> I'm not against this change since I've never used J in the agenda >> before >> (mostly because I wasn't aware of this key binding at all). > > C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers > and > to org-clock-goto is org buffers. > > I hesitated long, and I'm still not convinved this is the best choice. > > Since `J' is an agenda-only keybinding, maybe using `J' would make > more > sense. I have not looked up which way it is now, but thinking again it seems to me that this would be the right way: C-c C-x C-j jumps to the entry in the org buffer, both from the agenda and from normal buffers. "J" would then be available to find the clock entry in the agenda, if it is present there. We could extend this command to show the clock entry in the other window if the line cannot be found in the agenda window... - Carsten > > What's your take on this? > >> Is there a way to rebind agenda keys in case I want to use J for >> something different (similar to the user speed key settings?) > > (org-defkey org-agenda-mode-map "J" 'your-function) In general, he best way to do user keys is to bind them in the mode hook of the mode you need them for, in this case org-agenda-mode-hook. > >> I don't really want to overwrite the standard org-agenda-keymap >> bindings but it might be useful to have user bindings that on top of >> those as we do for the speed key settings. I think doing the hook think is good enough for this case. The speed key implementation is different. - Carsten