From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH] Proposed command: org-agenda-clock-goto Date: Sat, 07 Aug 2010 09:22:49 -0400 Message-ID: <87lj8id0ba.fsf@gollum.intra.norang.ca> References: <87pqy29344.fsf@gnu.org> <87pqxvd3u5.fsf@gollum.intra.norang.ca> <87lj8ikffv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=51212 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oi9ao-0002EG-EA for emacs-orgmode@gnu.org; Sun, 08 Aug 2010 13:23:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhjMX-0005or-ST for emacs-orgmode@gnu.org; Sat, 07 Aug 2010 09:22:59 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:61961) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhjMX-0005oj-Qx for emacs-orgmode@gnu.org; Sat, 07 Aug 2010 09:22:57 -0400 In-Reply-To: <87lj8ikffv.fsf@gnu.org> (Bastien's message of "Sat, 07 Aug 2010 10:14:12 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Noorul Islam Bastien writes: > Bernt Hansen writes: > >> I'm not against this change since I've never used J in the agenda before >> (mostly because I wasn't aware of this key binding at all). > > C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers and > to org-clock-goto is org buffers. > > I hesitated long, and I'm still not convinved this is the best choice. > > Since `J' is an agenda-only keybinding, maybe using `J' would make more > sense. > > What's your take on this? I currently have a binding for F11 that calls org-clock-goto so I'm unlikely to switch to using J -- mainly because F11 works everywhere for me and J only works in the agenda and on org-mode headings. > >> Is there a way to rebind agenda keys in case I want to use J for >> something different (similar to the user speed key settings?) > > (org-defkey org-agenda-mode-map "J" 'your-function) Thanks > >> I don't really want to overwrite the standard org-agenda-keymap >> bindings but it might be useful to have user bindings that on top of >> those as we do for the speed key settings. > > ... > > Mayby, if rebinding agenda keys is common. I personaly don't rebind > agenda keys. I currently don't rebind agenda keys -- I was just thinking if we're changing keys and people want their own definitions this might be useful. I'd skip implementing this until there's a real benefit from it. Regards, Bernt