Re: [PATCH] 3 improvements to ob-screen

[Kyle Meyer <kyle@kyleam.com>]

Ken Mankoff writes:

> I've signed the FSF docs but do not see my name here:
> https://orgmode.org/worg/org-contribute.html under "Current
> contributors".

Thanks for the information.  I'll add you to the list.

> Subject: [PATCH 1/3] ob-screen: Execute last line in block (send newline)

Could you add a changelog entry to the body of this commit message and
the others?  As an example, here's the one in the most recent commit on
master:

    * lisp/ox.el (org-export-smart-quotes-alist): Add Romanian variants for
      smart quotes.

> Subject: [PATCH 3/3] ob-screen: accept :screenrc header argument
>
> ---
>  etc/ORG-NEWS      | 6 ++++++
>  lisp/ob-screen.el | 5 +++--
>  2 files changed, 9 insertions(+), 2 deletions(-)

I didn't comment on this one elsewhere.  Looks good to me.

> diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
> index 623fa9dc3..5fb2af22e 100644
[...]
> diff --git a/lisp/ob-screen.el b/lisp/ob-screen.el
> index fe4698203..7115080f8 100644
> --- a/lisp/ob-screen.el
> +++ b/lisp/ob-screen.el
> @@ -40,7 +40,7 @@
>  In case you want to use a different screen than one selected by your $PATH")
>  
>  (defvar org-babel-default-header-args:screen
> -  '((:results . "silent") (:session . "default") (:cmd . "sh") (:terminal . "xterm"))
> +  '((:results . "silent") (:session . "default") (:cmd . "sh") (:terminal . "xterm") (:screenrc . "/dev/null"))
>    "Default arguments to use when running screen source blocks.")

nit-pick: Please move the new entry to the next line.