From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sOcDBTlzDl+QUwAA0tVLHw (envelope-from ) for ; Wed, 15 Jul 2020 03:08:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aGffADlzDl+MfAAAB5/wlQ (envelope-from ) for ; Wed, 15 Jul 2020 03:08:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C04EA9404D7 for ; Wed, 15 Jul 2020 03:08:39 +0000 (UTC) Received: from localhost ([::1]:44418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvXmf-0006xc-5X for larch@yhetil.org; Tue, 14 Jul 2020 23:08:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvXmH-0006xI-MO for emacs-orgmode@gnu.org; Tue, 14 Jul 2020 23:08:13 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:60750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvXmD-0005Tp-PU for emacs-orgmode@gnu.org; Tue, 14 Jul 2020 23:08:13 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8CEA8732BF; Tue, 14 Jul 2020 23:08:07 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=LnwZ7hFuAT+GXEtvsSkW+7eg3J8=; b=w8I6w7 r3h7bNNHPZ2nLpB1xW+xQApucN6oQCJY9eCDHO7bEr+/iivFk9vzerXyLReidnsC a1pylnyYju9/1JDUKP9k5f5Ln1yu+8l5nb+1QcM9vW7spcFxFJurlZgPeQSyle1f wwAumw5SgC4wnpYmjvkPkxq38M8hQwo5ylRbk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 7D734732BE; Tue, 14 Jul 2020 23:08:07 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=BIaqxqvOuOymbMMRAIT/Lu1r3cj9STFra3OkD6QBOFs=; b=qlmhG0m8Z/r+nz7IwTfJQ8KNK5lyALsdoHKZ3Woys17itl5aSu4eAG2icGoNpCLvrvYylW80V/1DK0sXMsiDOSTELgdvKqYVpOV9nlLl6bKf+mft342X/IqtewTJQJxhsbaXAGQPmhSVuG6e7oTI7i0y5FomdSoJRPjrKLAprQM= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D6F31732BD; Tue, 14 Jul 2020 23:08:06 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Ken Mankoff Subject: Re: [PATCH] 3 improvements to ob-screen In-Reply-To: <87h7u93j8b.fsf@gmail.com> References: <877dvcsmgu.fsf@gmail.com> <874kqa66hb.fsf@kyleam.com> <87h7u93j8b.fsf@gmail.com> Date: Tue, 14 Jul 2020 23:08:06 -0400 Message-ID: <87pn8x4grt.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 67C2A526-C648-11EA-A383-2F5D23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/14 23:08:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=w8I6w7 r; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=qlmhG0m8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: oGwy4JERp7I+ Ken Mankoff writes: > I've signed the FSF docs but do not see my name here: > https://orgmode.org/worg/org-contribute.html under "Current > contributors". Thanks for the information. I'll add you to the list. > Subject: [PATCH 1/3] ob-screen: Execute last line in block (send newline) Could you add a changelog entry to the body of this commit message and the others? As an example, here's the one in the most recent commit on master: * lisp/ox.el (org-export-smart-quotes-alist): Add Romanian variants for smart quotes. > Subject: [PATCH 3/3] ob-screen: accept :screenrc header argument > > --- > etc/ORG-NEWS | 6 ++++++ > lisp/ob-screen.el | 5 +++-- > 2 files changed, 9 insertions(+), 2 deletions(-) I didn't comment on this one elsewhere. Looks good to me. > diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS > index 623fa9dc3..5fb2af22e 100644 [...] > diff --git a/lisp/ob-screen.el b/lisp/ob-screen.el > index fe4698203..7115080f8 100644 > --- a/lisp/ob-screen.el > +++ b/lisp/ob-screen.el > @@ -40,7 +40,7 @@ > In case you want to use a different screen than one selected by your $PATH") > > (defvar org-babel-default-header-args:screen > - '((:results . "silent") (:session . "default") (:cmd . "sh") (:terminal . "xterm")) > + '((:results . "silent") (:session . "default") (:cmd . "sh") (:terminal . "xterm") (:screenrc . "/dev/null")) > "Default arguments to use when running screen source blocks.") nit-pick: Please move the new entry to the next line.