emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Ken Mankoff <mankoff@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)]
Date: Tue, 14 Jul 2020 00:55:12 -0400	[thread overview]
Message-ID: <874kqa66hb.fsf@kyleam.com> (raw)
In-Reply-To: <877dvcsmgu.fsf@gmail.com>

Ken Mankoff writes:

> Using ob-screen and this example:
> #+begin_src screen
> ls
> #+end_src
> The "ls" is transmitted to the screen session, but without a newline,
> it does not execute.

I see that on my end too.  I've never used ob-screen, and, with this
sort of issue, the same might be true for nearly everybody, assuming
this wasn't a recent regression.  (I don't spot any obvious culprits.)

> The following patch adds a newline to all babel blocks sent to the screen session.
> diff --git a/lisp/ob-screen.el b/lisp/ob-screen.el
> index 75a2dc691..5616143fe 100644
> --- a/lisp/ob-screen.el
> +++ b/lisp/ob-screen.el
> @@ -108,7 +108,7 @@ In case you want to use a different screen than one selected by your $PATH")
>    (let ((tmpfile (org-babel-temp-file "screen-")))
>      (with-temp-file tmpfile
>        (insert body)
> -
> +      (insert "\n")
>        ;; org-babel has superfluous spaces
>        (goto-char (point-min))
>        (delete-matching-lines "^ +$"))

Thanks.  Looks good and seems to work on my end.  Could prepare that as
a patch with a commit message (details at

  reply	other threads:[~2020-07-14  4:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 16:05 Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)] Ken Mankoff
2020-07-14  4:55 ` Kyle Meyer [this message]
2020-07-14 21:00   ` [PATCH] 3 improvements to ob-screen Ken Mankoff
2020-07-15  3:08     ` Kyle Meyer
2020-07-15 15:48       ` Ken Mankoff
2020-07-16  3:01         ` Kyle Meyer
2020-07-16  3:12           ` Kyle Meyer
2020-07-16  4:46             ` Ken Mankoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kqa66hb.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mankoff@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).