emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ken Mankoff <mankoff@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] 3 improvements to ob-screen
Date: Wed, 15 Jul 2020 21:46:32 -0700	[thread overview]
Message-ID: <87d04w12zb.fsf@gmail.com> (raw)
In-Reply-To: <87r1tcup99.fsf@kyleam.com>


On 2020-07-15 at 20:12 -07, Kyle Meyer <kyle@kyleam.com> wrote...
> Well, applied, but not pushed yet. In the second patch, the session
> name is no longer passed to string-match; it was in the original patch
> at <https://orgmode.org/list/874kqgsm1o.fsf@gmail.com>. I'll fix it up
> locally before pushing.

Argh - I apologize for introducing that bug. Thank you for catching it and accepting the patches. I'll look at the tweaks you made to the commit messages to learn what is preferred for my next contribution.

  -k.


      reply	other threads:[~2020-07-16  4:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 16:05 Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)] Ken Mankoff
2020-07-14  4:55 ` Kyle Meyer
2020-07-14 21:00   ` [PATCH] 3 improvements to ob-screen Ken Mankoff
2020-07-15  3:08     ` Kyle Meyer
2020-07-15 15:48       ` Ken Mankoff
2020-07-16  3:01         ` Kyle Meyer
2020-07-16  3:12           ` Kyle Meyer
2020-07-16  4:46             ` Ken Mankoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d04w12zb.fsf@gmail.com \
    --to=mankoff@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).