From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KAWXO9s6DV9MCAAA0tVLHw (envelope-from ) for ; Tue, 14 Jul 2020 04:55:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kPZ9N9s6DV+sXwAA1q6Kng (envelope-from ) for ; Tue, 14 Jul 2020 04:55:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3D3E9401AE for ; Tue, 14 Jul 2020 04:55:54 +0000 (UTC) Received: from localhost ([::1]:47622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvCyv-0000Pw-Cg for larch@yhetil.org; Tue, 14 Jul 2020 00:55:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvCyY-0000Pl-0N for emacs-orgmode@gnu.org; Tue, 14 Jul 2020 00:55:30 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:53071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvCyU-0005FU-51 for emacs-orgmode@gnu.org; Tue, 14 Jul 2020 00:55:28 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 741A9D02FE; Tue, 14 Jul 2020 00:55:22 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=tzM+gL0mZGrQiAmqVHlgWJOGn5Y=; b=mfa/zS eqpVVdowi4gt4KmLNGPqyM+s8ke+edZPTRUxu4k/v6UKj9zZ8u0zU2yhuazwal2z uCdSCLROx8xP8ZhUmRxws3slNtOLT4MjtdnItONHcNj/X4ytjmKv8DUlLT/rXTqI FJ5AhYySXzdmgYStJb0XA+eLKDu2hhVLo3oco= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5B1C3D02FD; Tue, 14 Jul 2020 00:55:22 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=ZG4aIKE8oVul4Ps/1KQ7uf6sUl5F7m7BVr0qY2BhH8U=; b=zKc0/6018Y0yvrJB+zJcE5JKchBvEiS8FuSsYgr4RhKUBXFARFr/j6BM1Rf99jeNxYVNJpN4ymGIqTQvJHWtg9HfnumXTd0b7D+UOKWBrIEbgN4xssAK17gfbgCq8e2y79y8diPCSzXNj7Uy3H8JuGE5LL88I1GUbhB5nc9V/ZY= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id CCE0ED02FC; Tue, 14 Jul 2020 00:55:19 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Ken Mankoff Subject: Re: Patch: send 'return' after babel blocks sent to ob-screen [9.3.7 (9.3.7-12-g5d6868-elpaplus @ /home/kdm/.emacs.d/elpa/org-plus-contrib-20200706/)] In-Reply-To: <877dvcsmgu.fsf@gmail.com> References: <877dvcsmgu.fsf@gmail.com> Date: Tue, 14 Jul 2020 00:55:12 -0400 Message-ID: <874kqa66hb.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 37B06A68-C58E-11EA-BA73-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/14 00:55:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=mfa/zS e; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=zKc0/601; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: 8MEe9oIda8Aq Ken Mankoff writes: > Using ob-screen and this example: > > #+begin_src screen > ls > #+end_src > > The "ls" is transmitted to the screen session, but without a newline, > it does not execute. I see that on my end too. I've never used ob-screen, and, with this sort of issue, the same might be true for nearly everybody, assuming this wasn't a recent regression. (I don't spot any obvious culprits.) > The following patch adds a newline to all babel blocks sent to the screen session. > > diff --git a/lisp/ob-screen.el b/lisp/ob-screen.el > index 75a2dc691..5616143fe 100644 > --- a/lisp/ob-screen.el > +++ b/lisp/ob-screen.el > @@ -108,7 +108,7 @@ In case you want to use a different screen than one selected by your $PATH") > (let ((tmpfile (org-babel-temp-file "screen-"))) > (with-temp-file tmpfile > (insert body) > - > + (insert "\n") > ;; org-babel has superfluous spaces > (goto-char (point-min)) > (delete-matching-lines "^ +$")) Thanks. Looks good and seems to work on my end. Could prepare that as a patch with a commit message (details at https://orgmode.org/worg/org-contribute.html)?