emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: "Juan Manuel Macías" <maciaschain@posteo.net>
Cc: orgmode <emacs-orgmode@gnu.org>
Subject: Re: [patch] Fix inner smart quotes in French
Date: Sat, 05 Aug 2023 13:19:23 +0000	[thread overview]
Message-ID: <87o7jlk4o4.fsf@localhost> (raw)
In-Reply-To: <87bkfl7of2.fsf@posteo.net>

Juan Manuel Macías <maciaschain@posteo.net> writes:

>> And it looks like at least on of the test conditions is not trivial to
>> fix without knowing French. May you or somebody familiar with French
>> punctuation take a look?
>
> I'm afraid I'm not very familiar with the syntax and usage of tests, so
> I have to study that part. I've been looking at
> `test-org-export/activate-smart-quotes', and I have a question: does it
> only include tests for English and French cases?

Yes, currently.

> First level quotes for French are «» with spaces, and second level ones
> (if I'm not mistaken) should be “”, without spaces (my patch fix).
> Therefore, I understand that a line like:
>
>    (equal '( "« outer « inner » outer »")
>
> should it be changed like this
>
>    (equal '( "« outer “inner” outer »")
>
> ?

That was exactly the piece of information I was missing.
I have no notion of "inner" quotes being different from "outer" in the
languages I am familiar with.

I now managed to fix the tests.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e4f127437

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2023-08-05 13:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  7:25 [patch] Fix inner smart quotes in French Juan Manuel Macías
2023-08-04 11:09 ` Bastien
2023-08-10 14:10   ` Max Nikulin
2023-08-10 14:49     ` Bastien
2023-08-10 16:01       ` Max Nikulin
2023-08-10 21:50       ` Juan Manuel Macías
2023-08-13  9:20         ` Bastien Guerry
2023-08-13  9:24           ` Ihor Radchenko
2023-08-13  9:46             ` Bastien Guerry
2023-08-13 12:57               ` Ihor Radchenko
2023-08-14 16:26                 ` Bastien Guerry
2023-08-15 11:23                   ` Ihor Radchenko
2023-08-22 15:11                     ` Bastien Guerry
2023-08-23  9:36                       ` Ihor Radchenko
2023-08-24 11:36                         ` Bastien Guerry
2023-08-05  7:08 ` Ihor Radchenko
2023-08-05 10:51   ` Juan Manuel Macías
2023-08-05 13:19     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7jlk4o4.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=maciaschain@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).