From: Bastien Guerry <bzg@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: "Juan Manuel Macías" <maciaschain@posteo.net>,
"Max Nikulin" <manikulin@gmail.com>,
orgmode <emacs-orgmode@gnu.org>
Subject: Re: [patch] Fix inner smart quotes in French
Date: Tue, 22 Aug 2023 17:11:02 +0200 [thread overview]
Message-ID: <87lee32juh.fsf@bzg.fr> (raw)
In-Reply-To: <87bkf8r1kr.fsf@localhost> (Ihor Radchenko's message of "Tue, 15 Aug 2023 11:23:48 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
> Bastien Guerry <bzg@gnu.org> writes:
>
>>>>> Are you referring to `org-export-smart-quotes-alist'? It is a defconst.
>>>>
>>>> Ah, indeed. I'd say using a defcustom here would be useful.
>>>
>>> Is changing defconst to defcustom ok for bugfix?
>>
>> Nope, it's more an "evolution" than a bugfix.
>
> Ok. I changed it to defcustom on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=570cdacdb
>
> Note, however, that we have `org-export-dictionary' as a constant.
> Also, language names are not standardized across
> `org-export-dictionary', `org-export-default-language',
> `org-clock-clocktable-language-setup', `org-export-smart-quotes-alist',
> and `org-latex-language-alist'.
From a quick look, I cannot find two conflicting language names (that
is, two strings like "fr" that refer to two distinct languages from
the variable you mention).
From the same quick look, I believe `org-export-dictionary' contains
more entries than other variables--we could use languages names from
this variable.
WDYT?
--
Bastien Guerry
next prev parent reply other threads:[~2023-08-22 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 7:25 [patch] Fix inner smart quotes in French Juan Manuel Macías
2023-08-04 11:09 ` Bastien
2023-08-10 14:10 ` Max Nikulin
2023-08-10 14:49 ` Bastien
2023-08-10 16:01 ` Max Nikulin
2023-08-10 21:50 ` Juan Manuel Macías
2023-08-13 9:20 ` Bastien Guerry
2023-08-13 9:24 ` Ihor Radchenko
2023-08-13 9:46 ` Bastien Guerry
2023-08-13 12:57 ` Ihor Radchenko
2023-08-14 16:26 ` Bastien Guerry
2023-08-15 11:23 ` Ihor Radchenko
2023-08-22 15:11 ` Bastien Guerry [this message]
2023-08-23 9:36 ` Ihor Radchenko
2023-08-24 11:36 ` Bastien Guerry
2023-08-05 7:08 ` Ihor Radchenko
2023-08-05 10:51 ` Juan Manuel Macías
2023-08-05 13:19 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lee32juh.fsf@bzg.fr \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=maciaschain@posteo.net \
--cc=manikulin@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).