From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Outline cycling does not preserve point's position
Date: Wed, 11 Sep 2013 13:09:48 +0200 [thread overview]
Message-ID: <87ioy78vib.fsf@gmail.com> (raw)
In-Reply-To: <8761u8m5sd.fsf@gmail.com> (Jambunathan K.'s message of "Wed, 11 Sep 2013 08:19:22 +0530")
Hello,
Jambunathan K <kjambunathan@gmail.com> writes:
> Some suggestions:
>
> 1. Give a better name. Say "pre-order" traversal of element in the
> parse tree. [1]
I don't know what "pre-order" means. What about
`org-flat-forward-element' or simply (but misleading) `org-forward-paragraph'?
> 3. When you say "Shouldn't be here", it means that point is NOT at the
> canonical C-down position. But you do seem to "adjust" it to the
> canonical position down below.
>
> May be you want to remove it or say something more positive like - In
> the middle of nowhere. Trying to get to the assembly point.
I don't understand. Are you talking about the error message? There is no
"canonical" C-down position, so I'm a bit confused.
>> New version:
>
> Couple of issues.
>
> 1. Visit the attached file. Make sure everything is visible.
> 2. M-<
> 3. C-down gives a stacktrace. See below.
Fixed.
> 1. Move to bol of the empty line that is in <<<Radioed Target>>> section. That
> is not an empty line but has spaces.
>
> 2. C-down
>
> 3. Cursor does NOT do a stop over at "References" headline but skips
> past to References to Fuzzy Target
That was a bug in `org-element-at-point', which is now fixed. Thank you.
You'll need to update Org.
New version, with comments and docstring:
(defun org-forward-linear-element ()
"Move forward to next element, ignoring depth.
The function implements some special moves for convenience:
- On an affiliated keyword, jump to the beginning of the
relative element.
- On an item or a footnote definition, move to the second
element inside, if any.
- On a table, jump after it.
- On a verse block, stop after each blank line."
(interactive)
(when (eobp) (user-error "Cannot move further down"))
(let* ((origin (point))
(element (org-element-at-point))
(type (org-element-type element))
(post-affiliated (org-element-property :post-affiliated element))
(contents-begin (org-element-property :contents-begin element))
(contents-end (org-element-property :contents-end element))
(end (let ((end (org-element-property :end element)) (parent element))
(while (and (setq parent (org-element-property :parent parent))
(= (org-element-property :contents-end parent) end))
(setq end (org-element-property :end parent)))
end)))
(skip-chars-forward " \r\t\n")
(or (eobp) (goto-char (max (line-beginning-position) origin)))
(cond ((or (eobp) (not end) (= (point) end)))
;; On affiliated keywords, move to element's beginning.
((and post-affiliated (< (point) post-affiliated))
(goto-char post-affiliated))
;; At a table row, move to the end of the table.
((eq type 'table-row)
(goto-char (org-element-property
:end (org-element-property :parent element))))
((eq type 'table) (goto-char end))
((not contents-begin) (goto-char end))
;; If current element contents are invisible, skip the
;; element.
((outline-invisible-p (line-end-position))
(if (not (eq type 'plain-list)) (goto-char end)
;; At a plain list, make sure we move to the next item
;; instead of skipping the whole list.
(forward-char)
(org-forward-linear-element)))
((< (point) contents-begin)
(if (not (memq type '(footnote-definition item)))
(goto-char contents-begin)
;; At footnote definitions and items, move to second
;; element, if any, or to next element otherwise.
(end-of-line)
(org-forward-linear-element)))
((>= (point) contents-end) (goto-char end))
((eq type 'paragraph) (goto-char end))
((eq type 'plain-list)
(end-of-line)
(org-forward-linear-element))
;; Verse blocks cannot contain paragraphs. Though, we
;; emulate them with blank lines separators to ease
;; editing.
((eq type 'verse-block)
(or (re-search-forward "^[ \t]*$" contents-end t)
(goto-char end)))
(t (error "This shouldn't happen")))))
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-09-11 11:09 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 12:11 Outline cycling does not preserve point's position Sebastien Vauban
2013-09-07 14:17 ` Carsten Dominik
[not found] ` <BED1FBAA-8BB5-45D6-8328-11C0BB2DF015-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-07 19:28 ` Sebastien Vauban
2013-09-08 6:16 ` Carsten Dominik
2013-09-09 7:57 ` Sebastien Vauban
2013-09-08 11:03 ` Eric Schulte
2013-09-09 8:39 ` Sebastien Vauban
2013-09-08 16:23 ` Carsten Dominik
2013-09-09 8:11 ` Sebastien Vauban
2013-09-09 8:13 ` Carsten Dominik
2013-09-09 8:23 ` Sebastien Vauban
2013-09-09 8:27 ` Carsten Dominik
2013-09-09 8:33 ` Sebastien Vauban
2013-09-09 8:38 ` Bastien
2013-09-09 9:05 ` Carsten Dominik
2013-09-09 11:32 ` Nicolas Goaziou
2013-09-09 11:49 ` Bastien
2013-09-09 15:27 ` Nicolas Goaziou
2013-09-09 14:23 ` Carsten Dominik
2013-09-09 15:16 ` Jambunathan K
2013-09-09 15:41 ` Nicolas Goaziou
2013-09-09 17:42 ` Sebastien Vauban
2013-09-10 3:47 ` Carsten Dominik
2013-09-10 6:03 ` Carsten Dominik
2013-09-10 6:48 ` Eric Abrahamsen
2013-09-10 7:32 ` Suvayu Ali
2013-09-10 7:53 ` Suvayu Ali
2013-09-10 7:58 ` Carsten Dominik
2013-09-10 8:16 ` Carsten Dominik
2013-09-10 8:50 ` Suvayu Ali
2013-09-10 9:02 ` Carsten Dominik
2013-09-10 9:50 ` Suvayu Ali
2013-09-10 16:33 ` Nicolas Goaziou
2013-09-10 18:35 ` Jambunathan K
2013-09-10 18:39 ` Nicolas Goaziou
2013-09-10 19:22 ` Jambunathan K
2013-09-10 19:40 ` Jambunathan K
2013-09-10 19:52 ` Nicolas Goaziou
2013-09-10 18:58 ` Suvayu Ali
2013-09-10 19:07 ` Suvayu Ali
2013-09-10 19:48 ` Nicolas Goaziou
2013-09-10 20:13 ` Suvayu Ali
2013-09-10 20:29 ` Nicolas Goaziou
2013-09-10 21:08 ` Carsten Dominik
2013-09-11 12:24 ` Suvayu Ali
2013-09-12 6:54 ` Jambunathan K
2013-09-12 9:11 ` Nicolas Goaziou
2013-09-12 9:28 ` Jambunathan K
2013-09-12 9:47 ` Suvayu Ali
2013-09-11 2:49 ` Jambunathan K
2013-09-11 11:09 ` Nicolas Goaziou [this message]
2013-09-11 11:34 ` Jambunathan K
2013-09-11 15:19 ` Nicolas Goaziou
2013-09-11 15:40 ` Jambunathan K
2013-09-11 15:31 ` Jambunathan K
2013-09-11 15:40 ` Nicolas Goaziou
2013-09-11 16:14 ` Jambunathan K
2013-09-11 20:01 ` Nicolas Goaziou
2013-09-11 22:11 ` Suvayu Ali
2013-09-12 6:43 ` Jambunathan K
2013-09-12 9:07 ` Nicolas Goaziou
2013-09-12 10:12 ` Jambunathan K
2013-09-12 7:17 ` Sebastien Vauban
2013-09-13 10:57 ` Carsten Dominik
2013-09-13 22:29 ` Nicolas Goaziou
2013-09-14 5:33 ` Carsten Dominik
2013-09-14 17:16 ` Suvayu Ali
2013-09-15 4:39 ` Carsten Dominik
2013-09-10 20:16 ` Samuel Wales
2013-09-10 5:06 ` Jambunathan K
2013-09-11 3:57 ` Jambunathan K
2013-09-11 15:47 ` Nicolas Goaziou
2013-09-09 8:38 ` Carsten Dominik
2013-09-09 11:30 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioy78vib.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).