From: Ihor Radchenko <yantar92@gmail.com>
To: Timothy <tecosaur@gmail.com>
Cc: Tom Gillespie <tgbugs@gmail.com>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fontification for inline src blocks
Date: Wed, 12 May 2021 23:53:50 +0800 [thread overview]
Message-ID: <87im3odk35.fsf@localhost> (raw)
In-Reply-To: <87fsys102j.fsf@gmail.com>
Timothy <tecosaur@gmail.com> writes:
>> I do not like abusing prettify-symbols-mode. What if it is not enabled?
>
> Ah, it does it anyway at the moment.
Hmm. You are right. You are calling compose-region directly. Note, that
you do not add 'decompose-region function for automatic region
destruction (see help:pretty-symbol-pattern-to-keyword). If I
understand correctly (I did not really install your patch), if you have
composed region, disable font-lock, and try to edit the region, edits
will be invisible. Or imagine setting org-inline-src-prettify-results to
nil in already fontified buffer.
Also, you may find help:font-lock-extra-managed-props useful. That way,
you will not have to manually remove composition and other non-standard
properties during fontification (why are you even removing 'face? It
should be already done by font-lock).
>> What will happen if user toggles prettify-symbols-mode in Org buffer?
>
> This seems to be toggled nicely by prettify-symbols-mode too.
I would not expect it to. Why would prettify-symbols-mode interfere with
Org mode native fontification if it is not strictly necessary?
P.S. Nitpick: You do not need to run fontification in while loops. Just
fontifying next match before limit should be enough. Font-lock will call
the function again if needed.
Best,
Ihor
next prev parent reply other threads:[~2021-05-12 15:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 15:00 [PATCH] Fontification for inline src blocks Timothy
2021-04-28 7:14 ` Timothy
2021-05-02 20:17 ` Timothy
2021-05-02 20:57 ` Tom Gillespie
2021-05-02 21:03 ` Timothy
2021-05-02 21:13 ` Tom Gillespie
2021-05-02 23:54 ` Tom Gillespie
2021-05-03 3:29 ` Timothy
2021-05-12 11:15 ` Timothy
2021-05-12 14:24 ` Ihor Radchenko
2021-05-12 14:47 ` Timothy
2021-05-12 15:53 ` Ihor Radchenko [this message]
2021-05-12 16:39 ` Timothy
2021-05-13 2:38 ` Tim Cross
2021-05-13 5:31 ` Ihor Radchenko
2021-05-18 12:06 ` Sébastien Miquel
2021-05-18 13:34 ` Timothy
2021-05-18 14:36 ` Sébastien Miquel
2021-04-29 22:59 ` TRS-80
2021-10-03 7:14 ` Ihor Radchenko
2021-10-03 7:16 ` Timothy
2021-10-03 9:09 ` Ihor Radchenko
2021-10-03 9:22 ` Timothy
2021-10-04 20:02 ` Protesilaos Stavrou
2021-11-21 14:09 ` Timothy
2021-11-22 11:52 ` Timothy
2021-11-22 12:23 ` Ihor Radchenko
2021-11-22 13:43 ` Timothy
2021-11-22 14:35 ` Ihor Radchenko
2021-11-22 14:37 ` Timothy
2021-11-23 13:30 ` Ihor Radchenko
2021-11-29 19:21 ` Timothy
2021-11-30 11:44 ` Timothy
2021-11-30 12:45 ` Sébastien Miquel
2021-11-30 12:46 ` Timothy
2021-11-30 12:21 ` Ihor Radchenko
2021-12-02 12:53 ` Eric S Fraga
2021-12-02 13:57 ` Faces for inline src blocks (was: [PATCH] Fontification for inline src blocks) Timothy
2021-12-02 15:52 ` Faces for inline src blocks Eric S Fraga
2021-12-02 15:56 ` Timothy
2021-12-02 16:15 ` Eric S Fraga
2021-11-23 10:45 ` [PATCH] Fontification " Vitaly Ankh
2021-11-23 13:45 ` Vitaly Ankh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im3odk35.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=tecosaur@gmail.com \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).