From: Timothy <email@example.com> To: Tom Gillespie <firstname.lastname@example.org> Cc: org-mode-email <email@example.com> Subject: Re: [PATCH] Fontification for inline src blocks Date: Mon, 03 May 2021 05:03:59 +0800 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CA+G3_PMta3Sgx-Hdz8h4=Giftk7TBsfB9TkftCFHfStFuJvsrQ@mail.gmail.com> Thanks for trying this! Tom Gillespie <email@example.com> writes: > Hi Timothy, > It seems to work more or less as expected. A few comments below. Best, > Tom > > 1. I think there needs to be a function to toggle > org-inline-src-prettify-results as there is e.g. for hyperlinks. I was > quite confused by the prettified results. I see. I imagine the expected behaviour of such a function would be to toggle org-inline-src-prettify-results and redisplay? > 2. I'm also not sure that this approach to prettify is a good idea. > There are issues with unexpected killing/yanking and basic navigation > behavior of the prettified text which seem worse than the already > troublesome issues with hyperlinks. I'm not sure we can do anything > about this though? If there is something that can be done, I'd love to hear about it. I'm no aware of anything though. > 3. I'm not sure about the default choice for prettified delimiters. I > see there is already a way to customize the delimiters by providing a > cons. I think a default value of '("" . "") might be a better choice > since ⟨ and ⟩ being hardcoded seems like it introduces completely > alien characters. Going with empty strings also seems consistent with > the behavior for hyperlinks. Hmmm, yes. Perhaps something else would make for a better default. I'm open to suggestions on this, I just didn't personally like any of the ASCII chars I tried when writing this. > 4. There is an interaction with rainbow delimiters that there isn't an > easy solution for. I wish there was a syntax type that was "this is a > paren for electric pair mode but not for font locking." This sounds like something worth being aware of, that nothing can really (currently) be done about. > 5. I'm not sure that the faces selected for src_ and lang are the > right ones. Is there any issue with adding new faces specifically for > those rather than reusing existing faces? I thought that matching the > font locking of #+begin_src lines might make sense, but then I > realized that that doesn't make sense because that is for blocks more > generally. I don't know if adding faces is a big deal or not, so I tried to pick "sensible choices" from the current set. Further input on this would be appreciated (particularly more people's thoughts). -- Timothy
next prev parent reply other threads:[~2021-05-02 21:04 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-31 15:00 Timothy 2021-04-28 7:14 ` Timothy 2021-05-02 20:17 ` Timothy 2021-05-02 20:57 ` Tom Gillespie 2021-05-02 21:03 ` Timothy [this message] 2021-05-02 21:13 ` Tom Gillespie 2021-05-02 23:54 ` Tom Gillespie 2021-05-03 3:29 ` Timothy 2021-05-12 11:15 ` Timothy 2021-05-12 14:24 ` Ihor Radchenko 2021-05-12 14:47 ` Timothy 2021-05-12 15:53 ` Ihor Radchenko 2021-05-12 16:39 ` Timothy 2021-05-13 2:38 ` Tim Cross 2021-05-13 5:31 ` Ihor Radchenko 2021-05-18 12:06 ` Sébastien Miquel 2021-05-18 13:34 ` Timothy 2021-05-18 14:36 ` Sébastien Miquel 2021-04-29 22:59 ` TRS-80 2021-10-03 7:14 ` Ihor Radchenko 2021-10-03 7:16 ` Timothy 2021-10-03 9:09 ` Ihor Radchenko 2021-10-03 9:22 ` Timothy 2021-10-04 20:02 ` Protesilaos Stavrou 2021-11-21 14:09 ` Timothy 2021-11-22 11:52 ` Timothy 2021-11-22 12:23 ` Ihor Radchenko 2021-11-22 13:43 ` Timothy 2021-11-22 14:35 ` Ihor Radchenko 2021-11-22 14:37 ` Timothy 2021-11-23 13:30 ` Ihor Radchenko 2021-11-29 19:21 ` Timothy 2021-11-30 11:44 ` Timothy 2021-11-30 12:45 ` Sébastien Miquel 2021-11-30 12:46 ` Timothy 2021-11-30 12:21 ` Ihor Radchenko 2021-12-02 12:53 ` Eric S Fraga 2021-12-02 13:57 ` Faces for inline src blocks (was: [PATCH] Fontification for inline src blocks) Timothy 2021-12-02 15:52 ` Faces for inline src blocks Eric S Fraga 2021-12-02 15:56 ` Timothy 2021-12-02 16:15 ` Eric S Fraga 2021-11-23 10:45 ` [PATCH] Fontification " Vitaly Ankh 2021-11-23 13:45 ` Vitaly Ankh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Fontification for inline src blocks' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).