Re: [BUG] Infinite loop in org-agenda-show-new-time

[Matt Lundin <mdl@imapmail.org>]

Nick Dokos <ndokos@gmail.com> writes:

> Matt Lundin <mdl@imapmail.org> writes:
>
>> ...
>> In other words, within the agenda buffer, move-to-column and
>> move-end-of-line will move to the point to the end of the entire
>> invisible region. That is why removing the local binding of
>> buffer-invisibility-spec to nil triggers this bug, because when that
>> variable is nil, the function org-agenda-show-new-time temporarily
>> treats the agenda buffer as if it were visible (i.e., it ignores the
>> invisible overlay).
>>
>
> I haven't been able to work on the problem, but assuming that your
> diagnosis above is correct, perhaps the thing to do is to bind
> buffeer-invisibility-spec to nil inside org-move-to-column:
>
> (defun org-move-to-column (column &optional force buffer)
>   (let ((buffer-invisibility-spec nil))
> 	(if (featurep 'xemacs)
> 	    (org-xemacs-without-invisibility (move-to-column column force buffer))
> 	  (move-to-column column force))))
>
> What do you think?

That solves the problem beautifully. Would it have any negative
side-effects for other org functions, especially those that invoke
org-move-to-column in normal org buffers?

Here's a list of such invocations:

--8<---------------cut here---------------start------------->8---
-*- mode: grep; default-directory: "~/org-mode/lisp/" -*-
Grep started at Wed Aug 14 10:14:17

grep -nH -e org-move-to-column *.el
org-agenda.el:8248:    (org-move-to-column col))
org-agenda.el:8260:      (org-move-to-column col)))
org-agenda.el:8766:      (org-move-to-column col))))
org-agenda.el:9130:	  (org-move-to-column (- (window-width) (length stamp)) t)
org-agenda.el:9232:      (org-move-to-column col))))
org-agenda.el:9252:    (org-move-to-column col)
org-clock.el:1851:    (org-move-to-column c)
org-colview.el:503:	(org-move-to-column col)
org-colview.el:632:      (org-move-to-column col)
org-compat.el:338:(defun org-move-to-column (column &optional force buffer)
org.el:9440:	   (if (< (current-column) gc) (org-move-to-column gc t) (insert " "))
org.el:14377:	  (org-move-to-column (min ncol col) t))
org.el:14532:	(org-move-to-column col)
org.el:14616:      (org-move-to-column (- (window-width) 19) t)
org.el:22037:      (org-move-to-column column))))
org.el:22465:		  (org-move-to-column min-indent t))
org.el:22588:	      (org-move-to-column cc t)
org.el:22593:	     ((not off) (org-move-to-column cc t) (insert ": ")))
org.el:23360:      (org-move-to-column c))))
org-list.el:2170:    (org-move-to-column col)))
org-list.el:2189:    (org-move-to-column col)))
org-macs.el:110:	 (org-move-to-column ,col)))))
org-src.el:358:	  (org-move-to-column
org-src.el:364:	(org-move-to-column
org-src.el:537:	(org-move-to-column (max 0 (- col block-nindent 2)))
org-src.el:771:	(org-move-to-column (if preserve-indentation col (+ col total-nindent delta)))))
org-table.el:1121:	  (org-move-to-column col)
org-table.el:1126:	  (org-move-to-column col))
org-table.el:1353:      (org-move-to-column col)
org-table.el:1358:	(org-move-to-column col))
org-table.el:1507:    (org-move-to-column col)
org-table.el:1559:    (org-move-to-column col)
org-table.el:1599:    (org-move-to-column col)

Grep finished (matches found) at Wed Aug 14 10:14:17
--8<---------------cut here---------------end--------------->8---

Matt