Re: [BUG] Infinite loop in org-agenda-show-new-time

[Nick Dokos <ndokos@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> I also do not expect negative consequences.  Please apply the patch, will you?
>

OK - patch attached. NB: there is at least one place where the "wrap the
call to org-move-to-column" has been applied, in
org.el:`org-comment-or-uncomment-region', presumably for exactly this
reason. If this patch does not cause unexpected problem, then the
wrapped setting above can be cleaned up.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch for Matt Lundin's infloop --]
[-- Type: text/x-diff, Size: 1532 bytes --]

From b0aebe182a72df8e7d5428a02e0eca7a6922fefe Mon Sep 17 00:00:00 2001
From: Nick Dokos <ndokos@gmail.com>
Date: Fri, 23 Aug 2013 07:42:44 -0400
Subject: [PATCH] Fix infinite loop in org-agenda-show-new-time

* lisp/org-agenda.el (org-move-to-column): Make sure that
  `buffer-invisibility-spec' is nil when calling move-to-column.

This was caused by a previous commit (fafb5f34) which eliminated the
setting of `buffer-invisibility-spec' in `org-agenda-show-new-time'.

Matt Lundin ran into this and there is a discussion on the ML:

   http://thread.gmane.org/gmane.emacs.orgmode/75288
---
 lisp/org-compat.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index d10aeea..c4d15d8 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -336,9 +336,12 @@ Works on both Emacs and XEmacs."
     (indent-line-to column)))
 
 (defun org-move-to-column (column &optional force buffer)
-  (if (featurep 'xemacs)
-      (org-xemacs-without-invisibility (move-to-column column force buffer))
-    (move-to-column column force)))
+  ;; set buffer-invisibility-spec to nil so that move-to-column
+  ;; does the right thing despite the presence of invisible text.
+  (let ((buffer-invisibility-spec nil))
+    (if (featurep 'xemacs)
+	(org-xemacs-without-invisibility (move-to-column column force buffer))
+      (move-to-column column force))))
 
 (defun org-get-x-clipboard-compat (value)
   "Get the clipboard value on XEmacs or Emacs 21."
-- 
1.8.3.101.g727a46b


[-- Attachment #3: Type: text/plain, Size: 77 bytes --]


I hope it conforms to conventions but let me know of any problems.
-- 
Nick