emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Andrew Hyatt <ahyatt@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Nick Dokos <ndokos@gmail.com>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time
Date: Tue, 4 Feb 2020 14:25:44 -0500	[thread overview]
Message-ID: <CAM6wYYKkbO3ZTTh-6q19LVjx_VRHY2q8WEFuCbs5Cfc6Ek90Uw@mail.gmail.com> (raw)
In-Reply-To: <87o8ufo5l8.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

I've tried the latest version from Feb 2nd, and it still has the same issue.

After some more time with the issue, the issue is when the agenda has items
A, and next line, invisibily (due to org-agenda-dim-blocked-tasks), B.
Trying to set A gets you into an invisible loop because moving to the start
of the line after displaying the time in org-agenda-show-new-time doesn't
take you far enough back to proceed backwards.  The next iteration through
the loop, the time will be re-displayed.

Removing the (beginning-of-line 1) at the end of the time display code in
that function, and substituting (org-agenda-previous-line) seems to fix
it.  I'm not sure if that's the right approach - the previous code didn't
use that function for a reason, but I don't know what that reason was.

On Mon, Feb 3, 2020 at 2:04 PM Bastien <bzg@gnu.org> wrote:

> Hi Andrew,
>
> I have pushed some fixes in this area, if you have a chance to test
> Org from the latest maint or master branch, please do so and report
> if the problem persists.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 1443 bytes --]

  reply	other threads:[~2020-02-04 19:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 15:42 [BUG] Infinite loop in org-agenda-show-new-time Matt Lundin
2013-08-05 17:13 ` Nick Dokos
2013-08-05 20:14   ` Matt Lundin
2013-08-05 22:05     ` Nick Dokos
2013-08-06 17:36       ` Matt Lundin
2013-08-06 21:35         ` Nick Dokos
2013-08-06 22:45           ` Nick Dokos
2013-08-14 15:19             ` Matt Lundin
2013-08-14 15:38               ` Nick Dokos
2013-08-10 15:06         ` Nick Dokos
2013-08-14 15:15           ` Matt Lundin
2013-08-14 15:45             ` Nick Dokos
2013-08-23  9:58               ` Carsten Dominik
2013-08-23 12:07                 ` Nick Dokos
2019-12-26 19:37                   ` Andrew Hyatt
2020-02-01  9:32                     ` Bastien
2020-02-02 15:19                       ` Andrew Hyatt
2020-02-03 19:04                         ` Bastien
2020-02-04 19:25                           ` Andrew Hyatt [this message]
2020-02-04 23:38                             ` Bastien
2020-02-05 16:34                               ` Andrew Hyatt
2020-02-05 19:50                               ` Matthew Lundin
2020-02-11  7:56                                 ` Bastien
2020-02-14  3:27                                   ` Andrew Hyatt
2020-02-14 10:02                                     ` Bastien
2020-02-17 19:20                                       ` Andrew Hyatt
2020-02-17 22:53                                         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM6wYYKkbO3ZTTh-6q19LVjx_VRHY2q8WEFuCbs5Cfc6Ek90Uw@mail.gmail.com \
    --to=ahyatt@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=ndokos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).