From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: [BUG] Infinite loop in org-agenda-show-new-time Date: Wed, 14 Aug 2013 10:15:37 -0500 Message-ID: <87fvucuwva.fsf@fastmail.fm> References: <87zjswb0vq.fsf@fastmail.fm> <87siyojc2c.fsf@gmail.com> <87fvun6gku.fsf@fastmail.fm> <87ob9bkd4c.fsf@gmail.com> <87txj2lo0j.fsf@fastmail.fm> <87mwopinzv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9cng-0002u0-7S for emacs-orgmode@gnu.org; Wed, 14 Aug 2013 11:15:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9cna-0001lm-Ed for emacs-orgmode@gnu.org; Wed, 14 Aug 2013 11:15:52 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9cna-0001lS-9m for emacs-orgmode@gnu.org; Wed, 14 Aug 2013 11:15:46 -0400 In-Reply-To: <87mwopinzv.fsf@gmail.com> (Nick Dokos's message of "Sat, 10 Aug 2013 11:06:44 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nick Dokos Cc: emacs-orgmode@gnu.org Nick Dokos writes: > Matt Lundin writes: > >> ... >> In other words, within the agenda buffer, move-to-column and >> move-end-of-line will move to the point to the end of the entire >> invisible region. That is why removing the local binding of >> buffer-invisibility-spec to nil triggers this bug, because when that >> variable is nil, the function org-agenda-show-new-time temporarily >> treats the agenda buffer as if it were visible (i.e., it ignores the >> invisible overlay). >> > > I haven't been able to work on the problem, but assuming that your > diagnosis above is correct, perhaps the thing to do is to bind > buffeer-invisibility-spec to nil inside org-move-to-column: > > (defun org-move-to-column (column &optional force buffer) > (let ((buffer-invisibility-spec nil)) > (if (featurep 'xemacs) > (org-xemacs-without-invisibility (move-to-column column force buffer)) > (move-to-column column force)))) > > What do you think? That solves the problem beautifully. Would it have any negative side-effects for other org functions, especially those that invoke org-move-to-column in normal org buffers? Here's a list of such invocations: --8<---------------cut here---------------start------------->8--- -*- mode: grep; default-directory: "~/org-mode/lisp/" -*- Grep started at Wed Aug 14 10:14:17 grep -nH -e org-move-to-column *.el org-agenda.el:8248: (org-move-to-column col)) org-agenda.el:8260: (org-move-to-column col))) org-agenda.el:8766: (org-move-to-column col)))) org-agenda.el:9130: (org-move-to-column (- (window-width) (length stamp)) t) org-agenda.el:9232: (org-move-to-column col)))) org-agenda.el:9252: (org-move-to-column col) org-clock.el:1851: (org-move-to-column c) org-colview.el:503: (org-move-to-column col) org-colview.el:632: (org-move-to-column col) org-compat.el:338:(defun org-move-to-column (column &optional force buffer) org.el:9440: (if (< (current-column) gc) (org-move-to-column gc t) (insert " ")) org.el:14377: (org-move-to-column (min ncol col) t)) org.el:14532: (org-move-to-column col) org.el:14616: (org-move-to-column (- (window-width) 19) t) org.el:22037: (org-move-to-column column)))) org.el:22465: (org-move-to-column min-indent t)) org.el:22588: (org-move-to-column cc t) org.el:22593: ((not off) (org-move-to-column cc t) (insert ": "))) org.el:23360: (org-move-to-column c)))) org-list.el:2170: (org-move-to-column col))) org-list.el:2189: (org-move-to-column col))) org-macs.el:110: (org-move-to-column ,col))))) org-src.el:358: (org-move-to-column org-src.el:364: (org-move-to-column org-src.el:537: (org-move-to-column (max 0 (- col block-nindent 2))) org-src.el:771: (org-move-to-column (if preserve-indentation col (+ col total-nindent delta))))) org-table.el:1121: (org-move-to-column col) org-table.el:1126: (org-move-to-column col)) org-table.el:1353: (org-move-to-column col) org-table.el:1358: (org-move-to-column col)) org-table.el:1507: (org-move-to-column col) org-table.el:1559: (org-move-to-column col) org-table.el:1599: (org-move-to-column col) Grep finished (matches found) at Wed Aug 14 10:14:17 --8<---------------cut here---------------end--------------->8--- Matt