Re: Re: Fontification of blocks

["Eric Schulte" <schulte.eric@gmail.com>]

Hi Seb,

I was thinking that it would be nice to be able to try this out through
setting a variable (as most org customizations are handled) which would
activate/de-activate the extra fontification.  I think that adding a new
block delimiter face which inherits from the org-meta face as you've
suggested is the way to go.

I would recommend however that rather than removing/changing the
org-meta-line, quote and verse delimiting faces to cover the entire line
you simply add the org-block-begin/end-line face overtop of these
existing faces.  That way the default behavior is not changed by the
patch, and users have more control over the final display.

In fact rather than having the org-block-begin/end-line faces inherit
from org-meta-line why not have them begin as empty faces.  Do you think
this sounds like a good way to go?  If so would you mind submitting a
patch which
- doesn't remove existing faces but rather adds these new faces overtop
  of them
- includes of definition of the org-block-begin/end-line faces to empty
  faces (otherwise the elisp compiler will warn of references to
  undefined variables)

Also, could you share an example code snippet which initializes the
org-block-begin/end-line faces initialized (either here and/or on worg)?

Many Thanks -- Eric

Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Eric,
>
> "Eric Schulte" wrote:
>> Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
>>> In order to make the blocks stand out more clearly in the mix of prose,
>>> code and table results of many Babel Org files, I've added 2 new faces:
>>>
>>> - org-block-begin-line
>>> - org-block-end-line
>>>
>>> These apply to the line just before and after the block's body:
>>>
>>> #+srcname: top-10-dossiers-with-many-prestations
>>> #+begin_src sql                                     <<< org-block-begin-line
>>> SELECT TOP 10 prsPfiID_fk, COUNT(*) AS '# Prestations'
>>> FROM prestations
>>> GROUP BY prsPfiID_fk
>>> ORDER BY COUNT(*) DESC
>>> #+end_src                                             <<< org-block-end-line
>>>
>>> Not only for =src=, but also for =verse=, =quote=, etc.
>>
>> This looks like a very nice addition.  Could you refactor your patch so
>> that this behavior is controlled by a user configurable defcustom
>> variable?
>
> For sure, I'm willing whatever is needed to make it more acceptable. But I'm
> not sure about the purpose of that variable...
>
> You want something such as =org-have-extra-faces=, and in case of:
>
> - =t=, use them
> - =nil=, use the old face =org-meta-line=.
>
> Is is that? I find that to be uselessly complexifying the fontification code.
> What was in my mind was have 2 new deffaces (not provided in the patch), with
> the same default value (or even an inherit property, that's much better) as
> =org-meta-line=.
>
> Wouldn't that be better?  In the case of the inheritage, if not customized in
> the color theme, the user would not see any change (I guess)...
>
> FYI, my intention is to add different faces as well for header arguments and
> their values...
>
> Best regards,
>   Seb