From: "Eric Schulte" <schulte.eric@gmail.com>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Fontification of blocks
Date: Mon, 13 Dec 2010 12:50:03 -0700 [thread overview]
Message-ID: <8739q1ihas.fsf@gmail.com> (raw)
In-Reply-To: <80aakevw4w.fsf@missioncriticalit.com> ("Sébastien Vauban"'s message of "Fri, 10 Dec 2010 10:02:07 +0100")
Hi Seb,
This looks like a very nice addition. Could you refactor your patch so
that this behavior is controlled by a user configurable defcustom
variable?
Thanks -- Eric
Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
> Hi,
>
> In order to make the blocks stand out more clearly in the mix of prose, code
> and table results of many Babel Org files, I've added 2 new faces:
>
> - org-block-begin-line
> - org-block-end-line
>
> These apply to the line just before and after the block's body:
>
> #+srcname: top-10-dossiers-with-many-prestations
> #+begin_src sql <<< org-block-begin-line
> SELECT TOP 10 prsPfiID_fk, COUNT(*) AS '# Prestations'
> FROM prestations
> GROUP BY prsPfiID_fk
> ORDER BY COUNT(*) DESC
> #+end_src <<< org-block-end-line
>
> Not only for =src=, but also for =verse=, =quote=, etc.
>
> This patch takes care of the correct fontification, both in native style, and
> in the "no native fontification" style:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index e03e9ca..f57c09b 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5137,8 +5137,8 @@ will be prompted for."
> (add-text-properties
> beg end
> '(font-lock-fontified t font-lock-multiline t))
> - (add-text-properties beg beg1 '(face org-meta-line))
> - (add-text-properties end1 (+ end 1) '(face org-meta-line))
> + (add-text-properties beg beg1 '(face org-block-begin-line))
> + (add-text-properties end1 (+ end 1) '(face org-block-end-line))
> ; for end_src
> (cond
> ((and lang org-src-fontify-natively)
> @@ -5149,9 +5149,9 @@ will be prompted for."
> ; end of source block
> ((not org-fontify-quote-and-verse-blocks))
> ((string= block-type "quote")
> - (add-text-properties beg1 end1 '(face org-quote)))
> + (add-text-properties beg1 (1+ end1) '(face org-quote)))
> ((string= block-type "verse")
> - (add-text-properties beg1 end1 '(face org-verse))))
> + (add-text-properties beg1 (1+ end1) '(face org-verse))))
> t))
> ((member dc1 '("title:" "author:" "email:" "date:"))
> (add-text-properties
> @@ -5167,7 +5167,7 @@ will be prompted for."
> ((not (member (char-after beg) '(?\ ?\t)))
> ;; just any other in-buffer setting, but not indented
> (add-text-properties
> - beg (match-end 0)
> + beg (1+ (match-end 0))
> '(font-lock-fontified t face org-meta-line))
> t)
> ((or (member dc1 '("begin:" "end:" "caption:" "label:"
>
> Best regards,
> Seb
next prev parent reply other threads:[~2010-12-13 19:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 9:02 Fontification of blocks Sébastien Vauban
2010-12-10 11:12 ` David O'Toole
2010-12-13 21:25 ` Sébastien Vauban
2010-12-22 13:36 ` Dan Davison
2010-12-22 14:46 ` Sébastien Vauban
2010-12-13 19:50 ` Eric Schulte [this message]
2010-12-13 20:46 ` Sébastien Vauban
2010-12-15 17:22 ` Eric Schulte
2011-02-01 21:04 ` Sébastien Vauban
2011-02-02 7:25 ` Eric S Fraga
2011-02-02 14:34 ` Dan Davison
2011-02-02 20:19 ` Sébastien Vauban
2011-02-07 12:54 ` Dan Davison
2011-02-07 19:55 ` Sébastien Vauban
2011-02-08 19:00 ` Dan Davison
2011-02-08 20:14 ` Sébastien Vauban
2011-02-09 8:40 ` Dan Davison
2011-02-02 22:24 ` Sébastien Vauban
2011-02-02 22:46 ` Eric S Fraga
2011-02-03 15:02 ` Eric Schulte
2011-02-03 19:57 ` Sébastien Vauban
2011-02-03 20:05 ` Eric S Fraga
2011-02-03 20:44 ` Sébastien Vauban
2011-02-04 9:21 ` Sébastien Vauban
2011-02-04 16:18 ` Eric S Fraga
2011-02-04 20:50 ` Eric Schulte
2011-02-06 8:52 ` Sébastien Vauban
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 9:01 Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739q1ihas.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).