From: "Eric Schulte" <schulte.eric@gmail.com>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: Fontification of blocks
Date: Wed, 15 Dec 2010 10:22:45 -0700 [thread overview]
Message-ID: <87ei9jkl0l.fsf@gmail.com> (raw)
In-Reply-To: 80r5dlpfj6.fsf@missioncriticalit.com
Hi Seb,
I was thinking that it would be nice to be able to try this out through
setting a variable (as most org customizations are handled) which would
activate/de-activate the extra fontification. I think that adding a new
block delimiter face which inherits from the org-meta face as you've
suggested is the way to go.
I would recommend however that rather than removing/changing the
org-meta-line, quote and verse delimiting faces to cover the entire line
you simply add the org-block-begin/end-line face overtop of these
existing faces. That way the default behavior is not changed by the
patch, and users have more control over the final display.
In fact rather than having the org-block-begin/end-line faces inherit
from org-meta-line why not have them begin as empty faces. Do you think
this sounds like a good way to go? If so would you mind submitting a
patch which
- doesn't remove existing faces but rather adds these new faces overtop
of them
- includes of definition of the org-block-begin/end-line faces to empty
faces (otherwise the elisp compiler will warn of references to
undefined variables)
Also, could you share an example code snippet which initializes the
org-block-begin/end-line faces initialized (either here and/or on worg)?
Many Thanks -- Eric
Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
> Hi Eric,
>
> "Eric Schulte" wrote:
>> Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
>>> In order to make the blocks stand out more clearly in the mix of prose,
>>> code and table results of many Babel Org files, I've added 2 new faces:
>>>
>>> - org-block-begin-line
>>> - org-block-end-line
>>>
>>> These apply to the line just before and after the block's body:
>>>
>>> #+srcname: top-10-dossiers-with-many-prestations
>>> #+begin_src sql <<< org-block-begin-line
>>> SELECT TOP 10 prsPfiID_fk, COUNT(*) AS '# Prestations'
>>> FROM prestations
>>> GROUP BY prsPfiID_fk
>>> ORDER BY COUNT(*) DESC
>>> #+end_src <<< org-block-end-line
>>>
>>> Not only for =src=, but also for =verse=, =quote=, etc.
>>
>> This looks like a very nice addition. Could you refactor your patch so
>> that this behavior is controlled by a user configurable defcustom
>> variable?
>
> For sure, I'm willing whatever is needed to make it more acceptable. But I'm
> not sure about the purpose of that variable...
>
> You want something such as =org-have-extra-faces=, and in case of:
>
> - =t=, use them
> - =nil=, use the old face =org-meta-line=.
>
> Is is that? I find that to be uselessly complexifying the fontification code.
> What was in my mind was have 2 new deffaces (not provided in the patch), with
> the same default value (or even an inherit property, that's much better) as
> =org-meta-line=.
>
> Wouldn't that be better? In the case of the inheritage, if not customized in
> the color theme, the user would not see any change (I guess)...
>
> FYI, my intention is to add different faces as well for header arguments and
> their values...
>
> Best regards,
> Seb
next prev parent reply other threads:[~2010-12-15 17:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 9:02 Fontification of blocks Sébastien Vauban
2010-12-10 11:12 ` David O'Toole
2010-12-13 21:25 ` Sébastien Vauban
2010-12-22 13:36 ` Dan Davison
2010-12-22 14:46 ` Sébastien Vauban
2010-12-13 19:50 ` Eric Schulte
2010-12-13 20:46 ` Sébastien Vauban
2010-12-15 17:22 ` Eric Schulte [this message]
2011-02-01 21:04 ` Sébastien Vauban
2011-02-02 7:25 ` Eric S Fraga
2011-02-02 14:34 ` Dan Davison
2011-02-02 20:19 ` Sébastien Vauban
2011-02-07 12:54 ` Dan Davison
2011-02-07 19:55 ` Sébastien Vauban
2011-02-08 19:00 ` Dan Davison
2011-02-08 20:14 ` Sébastien Vauban
2011-02-09 8:40 ` Dan Davison
2011-02-02 22:24 ` Sébastien Vauban
2011-02-02 22:46 ` Eric S Fraga
2011-02-03 15:02 ` Eric Schulte
2011-02-03 19:57 ` Sébastien Vauban
2011-02-03 20:05 ` Eric S Fraga
2011-02-03 20:44 ` Sébastien Vauban
2011-02-04 9:21 ` Sébastien Vauban
2011-02-04 16:18 ` Eric S Fraga
2011-02-04 20:50 ` Eric Schulte
2011-02-06 8:52 ` Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei9jkl0l.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).